You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/04/09 01:17:48 UTC

Review Request 45967: Added documentation for shareable resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4325
    https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
-------

Added documentation for shareable resources.


Diffs
-----

  docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
  docs/shareable-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha


Re: Review Request 45967: Added documentation for shareable resources.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/#review127943
-----------------------------------------------------------



Bad patch!

Reviews applied: [45967, 45966, 45964, 45963, 45962, 45961, 45960, 45959, 45958]

Failed command: ./support/apply-review.sh -n -r 45962

Error:
2016-04-09 01:33:58 URL:https://reviews.apache.org/r/45962/diff/raw/ [20685/20685] -> "45962.patch" [1]
src/examples/persistent_shared_volume_framework.cpp:249:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12416/console

- Mesos ReviewBot


On April 8, 2016, 11:17 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45967/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
>     https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for shareable resources.
> 
> 
> Diffs
> -----
> 
>   docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
>   docs/shareable-resources.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45967/diff/
> 
> 
> Testing
> -------
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Re: Review Request 45967: Added documentation for shareable resources.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/#review131047
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45958, 45959, 45960, 45961, 45962, 45963, 45964, 45966, 45967]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 12:16 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45967/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 12:16 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
>     https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for shareable resources.
> 
> 
> Diffs
> -----
> 
>   docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
>   docs/shareable-resources.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45967/diff/
> 
> 
> Testing
> -------
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Re: Review Request 45967: Added documentation for shareable resources.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45967/
-----------------------------------------------------------

(Updated April 29, 2016, 12:16 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-4325
    https://issues.apache.org/jira/browse/MESOS-4325


Repository: mesos


Description
-------

Added documentation for shareable resources.


Diffs (updated)
-----

  docs/home.md dc41fc4479e6c23650cd8ac78dcc4b9161d00721 
  docs/shareable-resources.md PRE-CREATION 

Diff: https://reviews.apache.org/r/45967/diff/


Testing
-------

Tests successful.


Thanks,

Anindya Sinha