You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/06 18:20:45 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #15606: [BEAM-12978] Customizable dependency for Java external transform

chamikaramj commented on a change in pull request #15606:
URL: https://github.com/apache/beam/pull/15606#discussion_r723565617



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ExternalTransformBuilder.java
##########
@@ -44,4 +47,12 @@
 
   /** Builds the transform after it has been configured. */
   PTransform<InputT, OutputT> buildExternal(ConfigT configuration);
+
+  /**
+   * List the dependencies needed for this transform. Jars from classpath are used by default when
+   * Optional.empty() is returned.
+   */
+  default Optional<List<String>> getDependencies(PipelineOptions options) {

Review comment:
       We should update the dev list regarding this interface change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org