[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5444: Enhance and simplify the filtering

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #5444:
URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r430777214



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/io/writer/SingleColumnMultiValueWriter.java
##########
@@ -19,60 +19,14 @@
 package org.apache.pinot.core.io.writer;
 
 public interface SingleColumnMultiValueWriter extends DataFileWriter {
-  /**

Review comment:
       we don't want to remove these. There are usecases where we will support no-dictionary modes

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/io/readerwriter/impl/FixedByteSingleColumnMultiValueReaderWriter.java
##########
@@ -277,42 +260,6 @@ public void setStringArray(int row, String[] stringArray) {
     }
   }
 
-  @Override

Review comment:
       why are we removing these methods, dont we need them for no-dictionary?

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java
##########
@@ -22,6 +22,8 @@
 
   boolean hasNext();
 
+  int getNextDocId();

Review comment:
       why is blockValIterator returning getNextDocId ?

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java
##########
@@ -21,6 +21,4 @@
 public interface BlockDocIdSet {
 
   BlockDocIdIterator iterator();
-

Review comment:
       this is awesome




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org