[GitHub] [beam] lostluck commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

[GitBox <gi...@apache.org>]

lostluck commented on pull request #16961:
URL: https://github.com/apache/beam/pull/16961#issuecomment-1085307480


   > So the vast majority of Python changes seem to be unrelated to this (mostly go specific, already very large) change. Is there a way we could break them out and review them separately? The one change I see is that we (now) have to do renaming of the proto files in apache_beam/portability/api back to a flat structure (and fix their internal imports).
   
   Milan can confirm, but since the changes are rooted in changing how the proto files import each other, I don't know how separable  each change at a PR level. 
   
   Might be able to organize the changes as commits with: "proto file changes" "generator changes" "go generated code" "python things."... granularity though.
   
   I'm ambivalent, since the go side is finished review at this point, and I don't understand the nature of the python side of the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org