You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/08/24 19:52:52 UTC
[14/17] incubator-beam git commit: Use AllPanes as the PaneExtractor
in IterableAssert
Use AllPanes as the PaneExtractor in IterableAssert
This ensures that tests with triggering in the global window which assert
on the entire PCollection (not a singleton iterable) will succeed over the
entire PCollection
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/d4b024ba
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/d4b024ba
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/d4b024ba
Branch: refs/heads/master
Commit: d4b024baecb99a259a79918c0554b85efc148120
Parents: e302cab
Author: Thomas Groh <tg...@google.com>
Authored: Thu Jul 28 08:26:43 2016 -0700
Committer: Kenneth Knowles <kl...@google.com>
Committed: Wed Aug 24 12:46:24 2016 -0700
----------------------------------------------------------------------
.../core/src/main/java/org/apache/beam/sdk/testing/PAssert.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/d4b024ba/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
index 943ed11..f02bbe0 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/PAssert.java
@@ -357,7 +357,7 @@ public class PAssert {
private final SimpleFunction<Iterable<WindowedValue<T>>, Iterable<T>> paneExtractor;
public PCollectionContentsAssert(PCollection<T> actual) {
- this(actual, IntoGlobalWindow.<T>of(), PaneExtractors.<T>onlyPane());
+ this(actual, IntoGlobalWindow.<T>of(), PaneExtractors.<T>allPanes());
}
public PCollectionContentsAssert(