You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2014/03/27 18:53:14 UTC
Review Request 19730: Bugfix: CLOUDSTACK-6292 live migration failed because
of VNC server address is not changed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19730/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Bugs: CLOUDSTACK-6292
https://issues.apache.org/jira/browse/CLOUDSTACK-6292
Repository: cloudstack-git
Description
-------
When migrating VM, VNC server IP address in domain xml need to be updated to destination KVM host IP address, but updated domain XML is left unused.
This patch changes MigrateKVMAsync class to accept domXml.
Diffs
-----
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1d7d1b2
Diff: https://reviews.apache.org/r/19730/diff/
Testing
-------
Live migration between two KVM hosts.
Thanks,
Yoshikazu Nojima
Re: Review Request 19730: Bugfix: CLOUDSTACK-6292 live migration failed
because of VNC server address is not changed
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19730/#review38833
-----------------------------------------------------------
will commit this. It works in our environment because of our /etc/libvirt/qemu.conf, I suppose.
- Marcus Sorensen
On March 27, 2014, 5:53 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19730/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6292
> https://issues.apache.org/jira/browse/CLOUDSTACK-6292
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When migrating VM, VNC server IP address in domain xml need to be updated to destination KVM host IP address, but updated domain XML is left unused.
> This patch changes MigrateKVMAsync class to accept domXml.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1d7d1b2
>
> Diff: https://reviews.apache.org/r/19730/diff/
>
>
> Testing
> -------
>
> Live migration between two KVM hosts.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 19730: Bugfix: CLOUDSTACK-6292 live migration failed
because of VNC server address is not changed
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19730/#review38834
-----------------------------------------------------------
Commit 7390f99afb4bd3da1d0fef5d8d16628f8c32180b in cloudstack's branch refs/heads/master from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7390f99 ]
CLOUDSTACK-6292: Fix live migration of KVM when vnc ip address
changes
Submitted-by: Yoshikazu Nojima
- ASF Subversion and Git Services
On March 27, 2014, 5:53 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19730/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6292
> https://issues.apache.org/jira/browse/CLOUDSTACK-6292
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When migrating VM, VNC server IP address in domain xml need to be updated to destination KVM host IP address, but updated domain XML is left unused.
> This patch changes MigrateKVMAsync class to accept domXml.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1d7d1b2
>
> Diff: https://reviews.apache.org/r/19730/diff/
>
>
> Testing
> -------
>
> Live migration between two KVM hosts.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 19730: Bugfix: CLOUDSTACK-6292 live migration failed
because of VNC server address is not changed
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19730/#review38835
-----------------------------------------------------------
Commit eacc1d7fff6812e0e4c70c290e295327b920e14b in cloudstack's branch refs/heads/4.4 from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eacc1d7 ]
CLOUDSTACK-6292: Fix live migration of KVM when vnc ip address
changes
Submitted-by: Yoshikazu Nojima
- ASF Subversion and Git Services
On March 27, 2014, 5:53 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19730/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 5:53 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-6292
> https://issues.apache.org/jira/browse/CLOUDSTACK-6292
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When migrating VM, VNC server IP address in domain xml need to be updated to destination KVM host IP address, but updated domain XML is left unused.
> This patch changes MigrateKVMAsync class to accept domXml.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1d7d1b2
>
> Diff: https://reviews.apache.org/r/19730/diff/
>
>
> Testing
> -------
>
> Live migration between two KVM hosts.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>