You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/30 18:16:58 UTC

[GitHub] [tvm] tqchen commented on pull request #8606: [BugFix][TensorIR] `specialize()` updates the `attrs` of PrimFuncs

tqchen commented on pull request #8606:
URL: https://github.com/apache/tvm/pull/8606#issuecomment-890069918


   It is anti-pattern to have attrs that refers to the body of a function(because there is no guarantee that every pass will update the corresponding attrs). So we should not support this kind of update. Instead, we should have well-form check if report an error if such pattern happens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org