You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/04/17 03:53:20 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #1923: [CALCITE-3884] Correct return type for SIGN with DECIMAL (Kyle Porter)

danny0405 commented on a change in pull request #1923: [CALCITE-3884] Correct return type for SIGN with DECIMAL (Kyle Porter)
URL: https://github.com/apache/calcite/pull/1923#discussion_r409977681
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
 ##########
 @@ -1714,7 +1714,7 @@ public SqlOperandCountRange getOperandCountRange() {
       new SqlFunction(
           "SIGN",
           SqlKind.OTHER_FUNCTION,
-          ReturnTypes.ARG0,
+          ReturnTypes.ARG0_OR_EXACT_NO_SCALE,
           null,
 
 Review comment:
   Thanks, can we give a test case, e.g. the SqlvalidatorTest and SqlOperatorBaseTest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services