You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2015/12/13 14:31:05 UTC
[1/2] git commit: updated refs/heads/4.6 to d7b7171
Repository: cloudstack
Updated Branches:
refs/heads/4.6 fcccaaad3 -> d7b717187
CLOUDSTACK-9155 make sure logrotate is effective
Many processes on the VRs log to cloud.log. When logrotate
kicks in, the file is rotated but the scripts still write
to the old inode (cloud.log.1 after rotate). Tis quickly
fills up the tiny log partition.
Using 'copytruncate' is a tradeoff, there is a slight
change of missing a log entry, but in the old situation
we were missing all of them after logrotate.
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/636efa2d
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/636efa2d
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/636efa2d
Branch: refs/heads/4.6
Commit: 636efa2da3a50e371b8a632a1d2ac43f85f04bfa
Parents: 1597a4c
Author: Remi Bergsma <gi...@remi.nl>
Authored: Sun Dec 13 11:53:45 2015 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Sun Dec 13 12:07:20 2015 +0100
----------------------------------------------------------------------
systemvm/patches/debian/config/etc/logrotate.d/cloud | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/636efa2d/systemvm/patches/debian/config/etc/logrotate.d/cloud
----------------------------------------------------------------------
diff --git a/systemvm/patches/debian/config/etc/logrotate.d/cloud b/systemvm/patches/debian/config/etc/logrotate.d/cloud
index 82801f1..b3a6a6d 100644
--- a/systemvm/patches/debian/config/etc/logrotate.d/cloud
+++ b/systemvm/patches/debian/config/etc/logrotate.d/cloud
@@ -22,4 +22,8 @@
notifempty
compress
delaycompress
+ # CLOUDSTACK-9155: We cannot tell the processes that are writing to this
+ # file to use the new inode, so instead we copy the original file, truncate
+ # it and keep the same inode.
+ copytruncate
}
[2/2] git commit: updated refs/heads/4.6 to d7b7171
Posted by re...@apache.org.
Merge pull request #1235 from remibergsma/fix-passwd-server-logging
CLOUDSTACK-9155 make sure logrotate is effective for cloud.logMany processes on the VRs log to cloud.log. When log rotate kicks in, the file is rotated but the scripts still write to the old inode (cloud.log.1 after rotate). Tis quickly fills up the tiny log partition.
Using 'copytruncate' is a small tradeoff, there is a slight change of missing a log entry, but in the old situation nothing ended up in cloud.log after rotate (except for stuff that was (re)started) so I think this is the best solution until we properly rewrite the script to either use their own script or syslog.
More details: https://issues.apache.org/jira/browse/CLOUDSTACK-9155
* pr/1235:
CLOUDSTACK-9155 make sure logrotate is effective
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/d7b71718
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/d7b71718
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/d7b71718
Branch: refs/heads/4.6
Commit: d7b7171870404cfbb1656a043fd42c93726ac8fb
Parents: fcccaaa 636efa2
Author: Remi Bergsma <gi...@remi.nl>
Authored: Sun Dec 13 14:30:07 2015 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Sun Dec 13 14:30:07 2015 +0100
----------------------------------------------------------------------
systemvm/patches/debian/config/etc/logrotate.d/cloud | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------