You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/13 22:53:38 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29517: Use "all" integrations to run tests when "all" is used
potiuk opened a new pull request, #29517:
URL: https://github.com/apache/airflow/pull/29517
The change #29449 made a distinction between "all" and "available" tests and it turned out that "All" test type uses "available" tests. The name "all" is actually wrong now. It should be renamed to be "all-with-tests" or similar, but this should be done in a separate PR
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #29517: Use "all" integrations to run tests when "all" is used
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #29517:
URL: https://github.com/apache/airflow/pull/29517#issuecomment-1428846845
Sorry about that,I didn't run into it in my testing. Is there a gap in the testing I should plug?
I'll take renaming the variable in another PR either today or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29517: Use "all" integrations to run tests when "all" is used
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29517:
URL: https://github.com/apache/airflow/pull/29517#issuecomment-1428815538
cc: @ferruzzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29517: Use "all" integrations to run tests when "all" is used
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29517:
URL: https://github.com/apache/airflow/pull/29517#issuecomment-1428858102
> Sorry about that,I didn't run into it in my testing. Is there a gap in the testing I should plug?
No problem. that's a bnit of complexity of commiter vs. non-commiter run. They are optimized differently.
> I'll take renaming the variable in another PR either today or tomorrow.
I am just about to create a PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29517: Use "all" integrations to run tests when "all" is used
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29517:
URL: https://github.com/apache/airflow/pull/29517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #29517: Use "all" integrations to run tests when "all" is used
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #29517:
URL: https://github.com/apache/airflow/pull/29517#issuecomment-1428864163
> I am just about to create a PR :)
Well fine then :stuck_out_tongue: :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org