You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 07:01:37 UTC
[GitHub] [pulsar] lhotari opened a new pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
lhotari opened a new pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962
Fixes #14961
### Motivation
BookKeeper 4.14.x isn't compatible with Rocksdb 6.29.4.1
```
2022-03-31T02:28:35,315+0000 [BookieHighPriorityThread-3181-OrderedExecutor-4-0] ERROR org.apache.bookkeeper.proto.ReadEntryProcessor - Unexpected exception reading at 20:-1 : 'org.rocksdb.ReadOptions org.rocksdb.ReadOptions.setIterateUpperBound(org.rocksdb.Slice)'
java.lang.NoSuchMethodError: 'org.rocksdb.ReadOptions org.rocksdb.ReadOptions.setIterateUpperBound(org.rocksdb.Slice)'
at org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDB.getFloor(KeyValueStorageRocksDB.java:257) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.storage.ldb.EntryLocationIndex.getLastEntryInLedgerInternal(EntryLocationIndex.java:106) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.storage.ldb.EntryLocationIndex.getLastEntryInLedger(EntryLocationIndex.java:99) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.storage.ldb.SingleDirectoryDbLedgerStorage.getLastEntry(SingleDirectoryDbLedgerStorage.java:559) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.storage.ldb.SingleDirectoryDbLedgerStorage.getEntry(SingleDirectoryDbLedgerStorage.java:401) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorage.getEntry(DbLedgerStorage.java:200) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.LedgerDescriptorImpl.readEntry(LedgerDescriptorImpl.java:160) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.bookie.Bookie.readEntry(Bookie.java:1500) ~[org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.proto.ReadEntryProcessor.processPacket(ReadEntryProcessor.java:83) [org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.proto.PacketProcessorBase.safeRun(PacketProcessorBase.java:106) [org.apache.bookkeeper-bookkeeper-server-4.14.4.jar:4.14.4]
at org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) [org.apache.bookkeeper-bookkeeper-common-4.14.4.jar:4.14.4]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.74.Final.jar:4.1.74.Final]
at java.lang.Thread.run(Thread.java:829) [?:?]
```
### Modifications
This reverts commit 12faf2d0888b075c8d43728117f87505b4bdc3dd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari edited a comment on pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari edited a comment on pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962#issuecomment-1084192562
In Java, it's possible to break binary compabitility ("ABI") without breaking API source compatibility.
here's the location where RocksDB ABI broke: https://github.com/facebook/rocksdb/commit/1001bc01c9ea06785c2d5261ca9fe7ac0eac0625#r69967694
This commit was included in RocksDB [6.17.3](https://github.com/facebook/rocksdb/releases/tag/v6.17.3). Code compiled with RocksDB <6.17.3 isn't compatible with a newer RocksDB version at runtime.
We need a Bookkeeper release that has been compiled with the new version before we can upgrade RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari edited a comment on pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari edited a comment on pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962#issuecomment-1084192562
In Java, it's possible to break binary compabitility ("ABI") without breaking API source compatibility.
here's the location where RocksDB ABI broke: https://github.com/facebook/rocksdb/commit/1001bc01c9ea06785c2d5261ca9fe7ac0eac0625#r69967694
This change happened in RocksDB [6.17.3](https://github.com/facebook/rocksdb/releases/tag/v6.17.3).
We need a Bookkeeper release that has been compiled with the new version before we can upgrade RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962#issuecomment-1084192562
In Java, it's possible to break binary compabitility ("ABI") without breaking API source compabitility.
here's the location where RocksDB ABI broke: https://github.com/facebook/rocksdb/commit/1001bc01c9ea06785c2d5261ca9fe7ac0eac0625#r69967694
We need a Bookkeeper release that has been compiled with the new version before we can upgrade RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962#issuecomment-1084185772
the problem was also referenced in https://github.com/apache/pulsar/issues/12166#issuecomment-1016745674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962#issuecomment-1085443760
"There is no guarantee of Binary Compatibility between RocksDB versions, I am afraid you will have to recompile."
https://github.com/facebook/rocksdb/commit/1001bc01c9ea06785c2d5261ca9fe7ac0eac0625#r70067997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #14962: Revert "Upgrade Rocksdb to 6.29.4.1 (#14886)"
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #14962:
URL: https://github.com/apache/pulsar/pull/14962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org