You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/10 01:21:54 UTC
[Impala-ASF-CR] IMPALA-4163: Add doc for sortby() hint
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5655
Change subject: IMPALA-4163: Add doc for sortby() hint
......................................................................
IMPALA-4163: Add doc for sortby() hint
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
2 files changed, 18 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/1
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 6: Code-Review+2
Apologies for the delay.
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 8: Code-Review+2
Carrying forward +2 after resolving merge conflict.
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4163: Add doc for sortby() hint
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-4163: Add doc for sortby() hint
......................................................................
IMPALA-4163: Add doc for sortby() hint
Add SORTBY() to list of hints in "Hints" topic.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 29 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/2
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5655
to look at the new patch set (#8).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Add CLUSTERED hint.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Finally, take out references to the SORTBY hint because
it didn't actually make it in. Intent for future is to have a way
to get this behavior without using a hint.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 71 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/8
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-4163: Add doc for sortby() hint
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4163: Add doc for sortby() hint
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Needs another patch set for sure.
http://gerrit.cloudera.org:8080/#/c/5655/1//COMMIT_MSG
Commit Message:
PS1, Line 7: Add doc for sortby() hint
In addition to this separate "Hints" topic, the hints relevant for INSERT statements are shown on the page for the INSERT statement. That page needs to be updated too. (That'll be patch set 2.)
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#6).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
Add CLUSTERED hint.
Revise SORTBY() with details from IMPALA-2522.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Finally, take out references to the SORTBY hint because
it didn't actually make it in. Intent for future is to have a way
to get this behavior without using a hint.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 78 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/6
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5655
to look at the new patch set (#7).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Add CLUSTERED hint.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Finally, take out references to the SORTBY hint because
it didn't actually make it in. Intent for future is to have a way
to get this behavior without using a hint.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 78 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/7
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 4:
(10 comments)
Thanks for the change. I added comments inline.
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
PS4, Line 2639: minimizes
Technically this is incorrect now, since CLUSTERED reduces the number of concurrent files even more. Maybe rephrase to "reduces".
PS4, Line 2672: perform organize
This reads as if one word was superfluous
PS4, Line 2674: risking
to reduce the risk of an...
PS4, Line 2686: large insert operations
: that use dynamic partitioning
This surprises me. Maybe I'm missing something?
Line 3707: <section id="kudu_common">
?
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:
Line 87: either the <codeph>/* */</codeph> or <codeph>--</codeph> notation.
We might want to state that the use of [] is discourage and will be deprecated in the next compatibility-breaking release of Impala.
PS4, Line 91: immediately before the hint name
It must only be present immediately before the hint list, i.e. the first hint name. For example /* +clustered,shuffle,sortby(a,b) */
Line 129: </codeblock>
we should have one example with multiple hints.
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/topics/impala_insert.xml
File docs/topics/impala_insert.xml:
Line 67: hint_with_dashes ::= -- +SHUFFLE | -- +NOSHUFFLE <ph rev="IMPALA-4163">| -- +SORTBY(<varname>col</varname>, <varname>col</varname> ...)]</ph>
Add CLUSTERED to the list?
Line 72: (Note: with this hint format, the square brackets are part of the syntax.)
Maybe mention that this will deprecated in the next compatibility-breaking release here, too?
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5655/6//COMMIT_MSG
Commit Message:
Line 9: Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
Nit: could you remove this?
Line 13: Revise SORTBY() with details from IMPALA-2522.
And this?
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 6:
John, let me know if you need Git/Gerrit help resolving the conflicts here.
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 4:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
PS4, Line 2639: minimizes
> Technically this is incorrect now, since CLUSTERED reduces the number of co
Done
PS4, Line 2672: perform organize
> This reads as if one word was superfluous
Took out "perform".
PS4, Line 2674: risking
> to reduce the risk of an...
Done
PS4, Line 2686: large insert operations
: that use dynamic partitioning
> This surprises me. Maybe I'm missing something?
Not applicable since this whole SORTBY piece is being removed.
Line 3707: <section id="kudu_common">
> ?
Just a minor housekeeping change for easier doc source maintenance.
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:
Line 87: either the <codeph>/* */</codeph> or <codeph>--</codeph> notation.
> We might want to state that the use of [] is discourage and will be depreca
Done
PS4, Line 91: immediately before the hint name
> It must only be present immediately before the hint list, i.e. the first hi
Done
Line 129: </codeblock>
> we should have one example with multiple hints.
I included an example like that in the discussion right before this list. Now with SORTBY gone, seems like the only combination for INSERT could be CLUSTERED and SHUFFLE or NOSHUFFLE. So I prefer not to repeat the same example twice so close together. Let's see how the result looks when all is said and done.
http://gerrit.cloudera.org:8080/#/c/5655/4/docs/topics/impala_insert.xml
File docs/topics/impala_insert.xml:
Line 67: hint_with_dashes ::= -- +SHUFFLE | -- +NOSHUFFLE <ph rev="IMPALA-4163">| -- +SORTBY(<varname>col</varname>, <varname>col</varname> ...)]</ph>
> Add CLUSTERED to the list?
Done. I added it under hints_with_dashes and hints_with_cstyle_comments. Not under hints_with_brackets.
Line 72: (Note: with this hint format, the square brackets are part of the syntax.)
> Maybe mention that this will deprecated in the next compatibility-breaking
Done
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 4:
Any news here?
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 4:
I heard from Lars (IMPALA-5157) that SORTBY should actually be removed. I guess abandoning this review is the wrong thing to do if CLUSTERED is still appropriate. I should do another patch set that keeps CLUSTERED and removes SORTBY.
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 6:
(2 comments)
Revised commit message.
http://gerrit.cloudera.org:8080/#/c/5655/6//COMMIT_MSG
Commit Message:
Line 9: Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
> Nit: could you remove this?
Done
Line 13: Revise SORTBY() with details from IMPALA-2522.
> And this?
Done
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 7:
John, can you rebase and resolve conflicts? This can't be merged as-is. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
Add CLUSTERED hint.
Revise SORTBY() with details from IMPALA-2522.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 58 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/3
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 6:
Lars can you take another look at this?
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#5).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
Add CLUSTERED hint.
Revise SORTBY() with details from IMPALA-2522.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Finally, take out references to the SORTBY hint because
it didn't actually make it in. Intent for future is to have a way
to get this behavior without using a hint.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 65 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/5
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Add CLUSTERED hint.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Finally, take out references to the SORTBY hint because
it didn't actually make it in. Intent for future is to have a way
to get this behavior without using a hint.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Reviewed-on: http://gerrit.cloudera.org:8080/5655
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 71 insertions(+), 28 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#4).
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
IMPALA-2522: Add doc for sortby() and clustered hints
Also IMPALA-4163: Add SORTBY() to list of hints in "Hints" topic.
Add CLUSTERED hint.
Revise SORTBY() with details from IMPALA-2522.
Update hint syntax in INSERT topic.
Also modernize the hint syntax as shown under INSERT
to include the -- and /* */ formats also. List
the [] style last since it is the least-preferred
option.
Switch to preferring /* */ syntax for hints
instead of using the [ ] notation by default.
Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
---
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
M docs/topics/impala_insert.xml
3 files changed, 87 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/5655/4
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2522: Add doc for sortby() and clustered hints
......................................................................
Patch Set 8:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/115/
--
To view, visit http://gerrit.cloudera.org:8080/5655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c1da9a87ace361b096fa73d8504b2f54e75bed
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No