You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Mahesh Raju Somalaraju (Jira)" <ji...@apache.org> on 2025/01/07 11:15:00 UTC

[jira] [Updated] (HIVE-27512) CalciteSemanticException.UnsupportedFeature enum to capital

     [ https://issues.apache.org/jira/browse/HIVE-27512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahesh Raju Somalaraju updated HIVE-27512:
------------------------------------------
    Status: Open  (was: Patch Available)

as per review it is suggested that better we not to disturb public exposed enums.

It is not any functional change. i just put the enum in proper readable format. If any other module is using this ENUM directly then better we can not disturb it. it causes compilation issues for other modules which are importing this enums directly.

> CalciteSemanticException.UnsupportedFeature enum to capital
> -----------------------------------------------------------
>
>                 Key: HIVE-27512
>                 URL: https://issues.apache.org/jira/browse/HIVE-27512
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: Mahesh Raju Somalaraju
>            Priority: Major
>              Labels: newbie, pull-request-available
>
> https://github.com/apache/hive/blob/3bc62cbc2d42c22dfd55f78ad7b41ec84a71380f/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java#L32-L39
> {code}
>   public enum UnsupportedFeature {
>     Distinct_without_an_aggreggation, Duplicates_in_RR, Filter_expression_with_non_boolean_return_type,
>     Having_clause_without_any_groupby, Invalid_column_reference, Invalid_decimal,
>     Less_than_equal_greater_than, Others, Same_name_in_multiple_expressions,
>     Schema_less_table, Select_alias_in_having_clause, Select_transform, Subquery,
>     Table_sample_clauses, UDTF, Union_type, Unique_join,
>     HighPrecissionTimestamp // CALCITE-1690
>   };
> {code}
> this just hurts my eyes, I expect it as DISTINCT_WITHOUT_AN_AGGREGATION ...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)