[GitHub] [hudi] dongkelun commented on a diff in pull request #5827: [HUDI-4218] The tableExists method should print the correct exception information when an exception occurs

[GitBox <gi...@apache.org>]

dongkelun commented on code in PR #5827:
URL: https://github.com/apache/hudi/pull/5827#discussion_r894522245


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -403,7 +403,7 @@ private static Boolean tableExists(Connection conn, Map<String, String> options)
       statement.setQueryTimeout(Integer.parseInt(options.get(JDBCOptions.JDBC_QUERY_TIMEOUT())));
       statement.executeQuery();
     } catch (SQLException e) {
-      return false;
+      e.printStackTrace();

Review Comment:
   I have considered throwing exceptions instead of printing exception information directly, but I haven't figured out the benefits of throwing exceptions.In other words, how to better handle exception information after throwing an exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org