[jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[Noorul Islam K M <no...@github.com>]

...t.
You can merge this Pull Request by running:

  git pull https://github.com/noorul/jclouds-chef jclouds-272

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-chef/pull/31

-- Commit Summary --

  * JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTest.

-- File Changes --

    M core/src/test/java/org/jclouds/chef/ChefApiExpectTest.java (19)
    M core/src/test/java/org/jclouds/chef/ChefApiTest.java (17)
    A core/src/test/resources/roles_list.json (4)

-- Patch Links --

https://github.com/jclouds/jclouds-chef/pull/31.patch
https://github.com/jclouds/jclouds-chef/pull/31.diff

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[Andrew Phillips <no...@github.com>]

+1 - looks good to me, too. Thanks, @noorul and @nacx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31#issuecomment-26404811

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[CloudBees pull request builder plugin <no...@github.com>]

[jclouds-chef-pull-requests #78](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/78/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31#issuecomment-26212390

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[CloudBees pull request builder plugin <no...@github.com>]

[jclouds-chef-pull-requests #80](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/80/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31#issuecomment-26212624

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[CloudBees pull request builder plugin <no...@github.com>]

[jclouds-chef-pull-requests #79](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/79/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31#issuecomment-26212564

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[Ignasi Barrera <no...@github.com>]

Closed #31.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31

Re: [jclouds-chef] JCLOUDS-272: Migrate list role test from ChefApiTest to ChefApiExpectTes... (#31)

[Ignasi Barrera <no...@github.com>]

Thanks @noorul!

I'll merge this PR, but after some discussions in the mailing list, we are improving the way we implement unit tests. We are switching to use [mockwebserver](http://code.google.com/p/mockwebserver/) instead of our custom mock (generated by the `requestSendsResponse` methods). The main difference when using mockwebserver is that the request is actually sent over the backing http connection, so the tests are more complete and give us more confidence that our apis work as expected.

It would be great to use that in upcoming pull requests. There are still no tests in jclouds-chef that use it, but if you are willing to start with a test base class we can reuse (and perhaps start changing some existing ExpectTest to the new MockTest), you can take a look at the MockTests classes in the [openstack-swift](https://github.com/jclouds/jclouds-labs-openstack/tree/master/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features) api to see an example of how they work (they are pretty similar to our Expect tests, though).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/31#issuecomment-26373391