[jira] [Commented] (KAFKA-6960) Remove the methods from the internal Scala AdminClient that are provided by the new AdminClient

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549527#comment-16549527 ] 

ASF GitHub Bot commented on KAFKA-6960:
---------------------------------------

asasvari opened a new pull request #5395: KAFKA-6960: Remove the methods from the internal Scala AdminClient th…
URL: https://github.com/apache/kafka/pull/5395
 
 
   …at are provided by the new AdminClient
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   This is a follow-up task of KAFKA-6884. 
   
   Remove all the methods from the internal Scala ``AdminClient`` that are provided by the new AdminClient. 
   - deleted: ``deleteConsumerGroups, describeConsumerGroup, listGroups, listAllGroups,  listAllGroupsFlattened``, 
   - updated ``LegacyAdminClientTest``. 
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   Deleted tests in ``LegacyAdminClientTest`` that validated the behaviour of the deleted methods in ``AdminClient.scala``.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove the methods from the internal Scala AdminClient that are provided by the new AdminClient
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6960
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6960
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Attila Sasvari
>            Assignee: Attila Sasvari
>            Priority: Major
>
> This is a follow-up task of KAFKA-6884. 
> We should remove all the methods from the internal Scala AdminClient that are provided by the new AdminClient. To "safe delete" them (i.e. {{deleteConsumerGroups, describeConsumerGroup, listGroups, listAllGroups,  listAllGroupsFlattened}}), related tests need to be reviewed and adjusted (for example: the tests in core_tests and streams_test). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)