You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/05/13 21:47:52 UTC

[jira] [Created] (HDFS-3419) Cleanup LocatedBlock

Eli Collins created HDFS-3419:
---------------------------------

             Summary: Cleanup LocatedBlock
                 Key: HDFS-3419
                 URL: https://issues.apache.org/jira/browse/HDFS-3419
             Project: Hadoop HDFS
          Issue Type: Improvement
    Affects Versions: 2.0.0
            Reporter: Eli Collins
            Assignee: Eli Collins


Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3419) Cleanup LocatedBlock

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3419:
------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.0
    Target Version/s:   (was: 2.0.0)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

No test since it's just cleanup.

Thanks Todd. I've committed this and merged to branch-2.
                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276000#comment-13276000 ] 

Hadoop QA commented on HDFS-3419:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526692/hdfs-3419.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2441//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2441//console

This message is automatically generated.
                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3419) Cleanup LocatedBlock

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3419:
------------------------------

    Status: Patch Available  (was: Open)
    
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3419) Cleanup LocatedBlock

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3419:
------------------------------

    Attachment: hdfs-3419.txt

Patch attached.
                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3419) Cleanup LocatedBlock

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-3419:
------------------------------

    Priority: Minor  (was: Major)
    
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274718#comment-13274718 ] 

Todd Lipcon commented on HDFS-3419:
-----------------------------------

{code}
     // create fake block of size 1 as a key
-    LocatedBlock key = new LocatedBlock();
+    LocatedBlock key = new LocatedBlock(
+        new ExtendedBlock(), new DatanodeInfo[0], 0L, false);
{code}

Strange that the comment size "size 1" but the block itself is size 0. Otherwise lgtm.
                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276721#comment-13276721 ] 

Hudson commented on HDFS-3419:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1045 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1045/])
    HDFS-3419. Cleanup LocatedBlock. Contributed by Eli Collins (Revision 1338802)

     Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338802
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlocks.java

                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276749#comment-13276749 ] 

Hudson commented on HDFS-3419:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1081 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1081/])
    HDFS-3419. Cleanup LocatedBlock. Contributed by Eli Collins (Revision 1338802)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338802
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlocks.java

                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276086#comment-13276086 ] 

Hudson commented on HDFS-3419:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2321 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2321/])
    HDFS-3419. Cleanup LocatedBlock. Contributed by Eli Collins (Revision 1338802)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338802
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlocks.java

                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3419) Cleanup LocatedBlock

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276096#comment-13276096 ] 

Hudson commented on HDFS-3419:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2247 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2247/])
    HDFS-3419. Cleanup LocatedBlock. Contributed by Eli Collins (Revision 1338802)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1338802
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlock.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LocatedBlocks.java

                
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3419) Cleanup LocatedBlock

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3419:
------------------------------

    Fix Version/s:     (was: 2.0.0)
                   2.0.1
    
> Cleanup LocatedBlock
> --------------------
>
>                 Key: HDFS-3419
>                 URL: https://issues.apache.org/jira/browse/HDFS-3419
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 2.0.1
>
>         Attachments: hdfs-3419.txt
>
>
> Remove dead code from LocatedBlock (which private/evolving, only used by hdfs) and give it a better javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira