You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/04 04:41:18 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
HyukjinKwon opened a new pull request, #42338:
URL: https://github.com/apache/spark/pull/42338
### What changes were proposed in this pull request?
The fix for the symmetry to https://github.com/apache/spark/pull/42282.
### Why are the changes needed?
See also https://github.com/apache/spark/pull/42282
### Does this PR introduce _any_ user-facing change?
See also https://github.com/apache/spark/pull/42282
### How was this patch tested?
See also https://github.com/apache/spark/pull/42282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42338:
URL: https://github.com/apache/spark/pull/42338#issuecomment-1665844976
Merged to master and branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
URL: https://github.com/apache/spark/pull/42338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42338:
URL: https://github.com/apache/spark/pull/42338#issuecomment-1664963753
cc @juliuszsompolski @zhengruifeng @ueshin Please take a look 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #42338:
URL: https://github.com/apache/spark/pull/42338#discussion_r1284499359
##########
python/pyspark/errors/exceptions/connect.py:
##########
@@ -188,3 +188,10 @@ class SparkUpgradeException(SparkConnectGrpcException, BaseSparkUpgradeException
"""
Exception thrown because of Spark upgrade from Spark Connect.
"""
+
+
+class SparkConnectRetryException(SparkConnectException):
+ """
+ An exception that can be thrown upstream when inside retry and which will be retryable
+ regardless of policy.
+ """
Review Comment:
nit: if this is an internal exception that is being thrown only inside Retrying, and not an user facing exception, should this be placed somewhere next to the AttemptManager and Retrying impl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42338: [SPARK-44671][PYTHON][CONNECT] Retry ExecutePlan in case initial request didn't reach server in Python client
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42338:
URL: https://github.com/apache/spark/pull/42338#discussion_r1284591468
##########
python/pyspark/errors/exceptions/connect.py:
##########
@@ -188,3 +188,10 @@ class SparkUpgradeException(SparkConnectGrpcException, BaseSparkUpgradeException
"""
Exception thrown because of Spark upgrade from Spark Connect.
"""
+
+
+class SparkConnectRetryException(SparkConnectException):
+ """
+ An exception that can be thrown upstream when inside retry and which will be retryable
+ regardless of policy.
+ """
Review Comment:
Actually yeah, fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org