You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 11:13:11 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #5486: travis: fix test/integration/component/test_public_ip.py

weizhouapache opened a new pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486


   ### Description
   
   This PR fixes a travis test failure after merging PR #5464.
   
   ROOT admin cannot list public ip address in the vlan ip ranges which are dedicated to other domain/user, we need to fix the issue in another PR.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486#issuecomment-924621563


   > @weizhouapache lgtm but doesn't it create an API regression?
   
   @rhtyd as I said in the description of this PR, there is indeed an issue.
   ROOT admin cannot list public ip address in the vlan ip ranges which are dedicated to other domain/user (if domain and account are not passed), we need to fix the issue in another PR.
   
   let's merge this pr so travis test passes (it always fails for now).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486#issuecomment-924733370


   @weizhouapache alright please submit another PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486#issuecomment-924521422


   @weizhouapache lgtm but doesn't it create an API regression? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486#issuecomment-924431154


   Ping for review @rhtyd @sureshanaparti @davidjumani  @shwstppr @Pearl1594 - Travis passing, no further tests needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486#issuecomment-924032091


   looks good
   ```
   Currently running test: component/test_public_ip
   /home/travis/.local/lib/python2.7/site-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.
     from cryptography.hazmat.backends import default_backend
   ==== Marvin Init Started ====
   === Marvin Parse Config Successful ===
   === Marvin Setting TestData Successful===
   ==== Log Folder Path: /tmp/MarvinLogs/Sep_21_2021_13_06_50_S1FGB4. All logs will be available here ====
   === Marvin Init Logging Successful===
   ==== Marvin Init Successful ====
   === TestName: test_01_list_publicip_root_domain | Status : SUCCESS ===
   === TestName: test_02_list_publicip_domain_admin | Status : SUCCESS ===
   === TestName: test_03_list_publicip_user_domain | Status : SUCCESS ===
   === TestName: test_04_list_publicip_all_subdomains | Status : SUCCESS ===
   === TestName: test_05_list_publicip_user_domain | Status : SUCCESS ===
   === TestName: test_06_list_publicip_user_domain | Status : SUCCESS ===
   ===final results are now copied to: /tmp/MarvinLogs/test_public_ip_AK5Q6S===
   real	0m21.808s
   user	0m0.848s
   sys	0m0.128s
   ```
   
   re-kick the test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache merged pull request #5486: travis: fix test/integration/component/test_public_ip.py

Posted by GitBox <gi...@apache.org>.
weizhouapache merged pull request #5486:
URL: https://github.com/apache/cloudstack/pull/5486


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org