You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/07/25 17:32:53 UTC
Review Request 12948: Affinity Groups: Adding new test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Adding new test cases for affinity groups
Diffs
-----
test/integration/component/test_affinity_groups.py 3f257c3
Diff: https://reviews.apache.org/r/12948/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 12948: Affinity Groups: Adding new test cases
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/#review23917
-----------------------------------------------------------
I changed quite a bit of this test suite last night. Can you please rebase against the latest changes. I saw your change only after I had made changes.
- Prasanna Santhanam
On July 25, 2013, 3:32 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12948/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 3:32 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding new test cases for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 3f257c3
>
> Diff: https://reviews.apache.org/r/12948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12948: Affinity Groups: Adding new test cases
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/#review23856
-----------------------------------------------------------
Review 12948 PASSED the build test
The url of build cloudstack-master-with-patch #40 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/40/
- Jenkins Cloudstack.org
On July 25, 2013, 3:32 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12948/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 3:32 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding new test cases for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 3f257c3
>
> Diff: https://reviews.apache.org/r/12948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12948: Affinity Groups: Adding new test cases
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/#review23954
-----------------------------------------------------------
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47788>
This will fail as delete is not a @classmethod no affinity groups anymore. use aff_group.delete(self.apiclient) instead
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47789>
I've separated the create_aff_grp() calls to actually return the aff_grp instead of append to a list in other tests.
Ideally I'd like to remove such utility methods within the tests altogether since they don't really provide clarity to the test scenario being executed. But that refactoring can be done once the tests are passed.
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47790>
Do we need to wait here? Can we just send for delete and exit so GC can take care?
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47791>
use debug statements. print will not show in the testrunner
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47792>
The tag 'multihost' is reserved for situations where the test requires multiple hosts to be executed successfully. Can you please remove that tag from the tests?
test/integration/component/test_affinity_groups.py
<https://reviews.apache.org/r/12948/#comment47793>
wait should not be required.
- Prasanna Santhanam
On July 26, 2013, 9:43 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12948/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 9:43 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding new test cases for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 3ecab6f
>
> Diff: https://reviews.apache.org/r/12948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12948: Affinity Groups: Adding new test cases
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/#review24981
-----------------------------------------------------------
Can you please close this review as discarded if these tests are already corrected?
- Prasanna Santhanam
On July 26, 2013, 9:43 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12948/
> -----------------------------------------------------------
>
> (Updated July 26, 2013, 9:43 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding new test cases for affinity groups
>
>
> Diffs
> -----
>
> test/integration/component/test_affinity_groups.py 3ecab6f
>
> Diff: https://reviews.apache.org/r/12948/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12948: Affinity Groups: Adding new test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12948/
-----------------------------------------------------------
(Updated July 26, 2013, 9:43 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
Updated diff against latest code
Repository: cloudstack-git
Description
-------
Adding new test cases for affinity groups
Diffs (updated)
-----
test/integration/component/test_affinity_groups.py 3ecab6f
Diff: https://reviews.apache.org/r/12948/diff/
Testing
-------
Thanks,
Gaurav Aradhye