You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by oxygen311 <gi...@git.apache.org> on 2018/08/07 12:17:06 UTC

[GitHub] zeppelin pull request #3115: Fix IndexError in python interpreter with empty...

GitHub user oxygen311 opened a pull request:

    https://github.com/apache/zeppelin/pull/3115

    Fix IndexError in python interpreter with empty input

    ### What is this PR for?
    If input of python or pyspark interpreter is empty (contains only comments), it will fail with `IndexError` from `zeppelin_python.py`.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-3687](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3687?filter=addedrecently)
    
    ### Screenshots
    ## Before:
    ![screen-shot-2018-08-05-at-23 29 34](https://user-images.githubusercontent.com/16215034/43775282-d1274caa-9a54-11e8-9c6c-3b882f96cf7e.jpg)
    ![screen-shot-2018-08-07-at-11 48 10](https://user-images.githubusercontent.com/16215034/43775285-d385ad2a-9a54-11e8-9a14-aa0080cc5824.jpg)
    
    ## After:
    ![screen-shot-2018-08-07-at-15 11 452](https://user-images.githubusercontent.com/16215034/43775306-e17acf28-9a54-11e8-8378-9b6a8b1c817c.jpg)
    ![screen-shot-2018-08-07-at-15 11 45](https://user-images.githubusercontent.com/16215034/43775313-e51f81c8-9a54-11e8-829f-d2aba1cc9613.jpg)
    
    
    ### Questions:
    * Does the licenses files need update? No 
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3115
    
----
commit 5d0fdd296af23f0a6fd34101615f281f184d3a94
Author: oxygen311 <al...@...>
Date:   2018-08-06T13:48:08Z

    Fix IndexError in python interpreter

----


---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3115


---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3115
  
    LGTM, did you configure travis ? I don't see your travis build 


---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 closed the pull request at:

    https://github.com/apache/zeppelin/pull/3115


---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:

    https://github.com/apache/zeppelin/pull/3115
  
    @zjffdu Done


---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

Posted by oxygen311 <gi...@git.apache.org>.
Github user oxygen311 commented on the issue:

    https://github.com/apache/zeppelin/pull/3115
  
    @zjffdu @felixcheung 
    Travis tests fixed


---

[GitHub] zeppelin pull request #3115: [ZEPPELIN-3687] Fix IndexError in python interp...

Posted by oxygen311 <gi...@git.apache.org>.
GitHub user oxygen311 reopened a pull request:

    https://github.com/apache/zeppelin/pull/3115

    [ZEPPELIN-3687] Fix IndexError in python interpreter with empty input

    ### What is this PR for?
    If input of python or pyspark interpreter is empty (contains only comments), it will fail with `IndexError` from `zeppelin_python.py`.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-3687](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3687)
    
    ### Screenshots
    ## Before:
    ![screen-shot-2018-08-05-at-23 29 34](https://user-images.githubusercontent.com/16215034/43775282-d1274caa-9a54-11e8-9c6c-3b882f96cf7e.jpg)
    ![screen-shot-2018-08-07-at-11 48 10](https://user-images.githubusercontent.com/16215034/43775285-d385ad2a-9a54-11e8-9a14-aa0080cc5824.jpg)
    
    ## After:
    ![screen-shot-2018-08-07-at-15 11 452](https://user-images.githubusercontent.com/16215034/43775306-e17acf28-9a54-11e8-8378-9b6a8b1c817c.jpg)
    ![screen-shot-2018-08-07-at-15 11 45](https://user-images.githubusercontent.com/16215034/43775313-e51f81c8-9a54-11e8-829f-d2aba1cc9613.jpg)
    
    
    ### Questions:
    * Does the licenses files need update? No 
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3115
    
----
commit 5d0fdd296af23f0a6fd34101615f281f184d3a94
Author: oxygen311 <al...@...>
Date:   2018-08-06T13:48:08Z

    Fix IndexError in python interpreter

commit ad8d07f5e58b94f1a780ec27cdf0c8d40e936af4
Author: Alexey <al...@...>
Date:   2018-08-08T10:25:51Z

    Add test for empty input

commit 54004b09864d913766bb21db38eb6ca716cdd8f6
Author: oxygen311 <al...@...>
Date:   2018-08-08T10:35:54Z

    Fix tests

----


---

[GitHub] zeppelin issue #3115: [ZEPPELIN-3687] Fix IndexError in python interpreter w...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3115
  
    Could you add unit test ?


---