You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/10/27 04:48:58 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3722: [CI] Skip CI when only docs are modified

wu-sheng commented on a change in pull request #3722: [CI] Skip CI when only docs are modified
URL: https://github.com/apache/skywalking/pull/3722#discussion_r339324982
 
 

 ##########
 File path: tools/ci/changed.sh
 ##########
 @@ -18,12 +18,18 @@
 
 patterns=()
 any_of=0
+all_of=0
 
+# --any-of: requires any of the changed files matche the given patterns
+# --all-of: requires all of the changed files matche the given patterns
 
 Review comment:
   Is this the right name? From your usage, if the all-of matched, the job is not working. But for the any-of, if  matched, the job runs. Seems different logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services