You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Cameron Lee (JIRA)" <ji...@apache.org> on 2018/12/11 18:56:00 UTC

[jira] [Created] (SAMZA-2036) MessageStreamAssert.containsInAnyOrder does not fail if there is an error

Cameron Lee created SAMZA-2036:
----------------------------------

             Summary: MessageStreamAssert.containsInAnyOrder does not fail if there is an error
                 Key: SAMZA-2036
                 URL: https://issues.apache.org/jira/browse/SAMZA-2036
             Project: Samza
          Issue Type: Bug
            Reporter: Cameron Lee


MessageStreamAssert.containsInAnyOrder uses a java.util.Timer to do verification. However, Timer will do the check in a background thread, and any error/exception does not get propagated to the main thread for the test. Therefore, any error will not cause a test to fail, so a test will pass even if there is an issue.

In addition, the MessageStreamAssert.CheckAgainstExpected helper class is broken, since the "expected" messages get cleared out when the operator graph is serialized then deserialized, and an NPE is thrown when trying to run "apply".

SchedulingTest and TestRepartitionJoinWindowApp both use MessageStreamAssert.containsInAnyOrder, and they pass, but they should fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)