You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 15:46:47 UTC
[GitHub] [airflow] josh-fell opened a new pull request, #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
josh-fell opened a new pull request, #25915:
URL: https://github.com/apache/airflow/pull/25915
When running the "Build and test provider packages wheel" test in CI, the following warning appears:
`WARNING: apache-airflow 2.2.0 does not provide the extra 'apache.atlas.apache.beam'`
Fixing the `AIRFLOW_EXTRAS` list by replacing a period with a comma.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224890096
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224888702
Thanks @potiuk! Fingers crossed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224322617
I was 100% sure I fixed it in [90338398a67cf8d8ffc6ed0418126d2d76002eb9](https://github.com/apache/airflow/commit/90338398a67cf8d8ffc6ed0418126d2d76002eb9) - I even wrote about it in the commit message :) . But indeed - I did not :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1225018485
Hey o! All green!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224324796
It needs to be re-pushed though - there was a temp failiure in image generation and I think that one need re-running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224874150
This one should fix the failure in Helm tests: https://github.com/apache/airflow/pull/25921 without reverting the postgres dependency change to optimized one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224889925
BTW. Always when i'm posting `:fingers-crossed:` emoji I type finger and this is the first answer on the list :🖕
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224919275
Seems it works :). At least it passed the stage where it failed before :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224888907
🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #25915:
URL: https://github.com/apache/airflow/pull/25915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1225018156
> BTW. Always when i'm posting `:fingers-crossed:` emoji I type finger and this is the first answer on the list :🖕
It IS the most emphatic finger for sure 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224858381
Hmm/ I think the psycopg2 binary changed messed with Helm chart I think we need to revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25915: Fix AIRFLOW_EXTRAS in CI for 2.2 build
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25915:
URL: https://github.com/apache/airflow/pull/25915#issuecomment-1224632872
> I was 100% sure I fixed it in [90338398a67cf8d8ffc6ed0418126d2d76002eb9](https://github.com/apache/airflow/commit/90338398a67cf8d8ffc6ed0418126d2d76002eb9) - I even wrote about it in the commit message :) . But indeed - I did not :D
Yes, same. I could have sworn that this was fixed before too. It looked too familiar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org