You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "plainheart (via GitHub)" <gi...@apache.org> on 2023/06/08 12:20:57 UTC
[GitHub] [echarts] plainheart opened a new pull request, #18733: fix(sankey): fix `value` is undefined in label/edgeLabel formatter
plainheart opened a new pull request, #18733:
URL: https://github.com/apache/echarts/pull/18733
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
1. Revert changes made in #18222 to fix `value` is undefined in label formatter callback.
See #18729.
2. Correctly fix `value` is undefined in sankey `label` & `edgeLabel` formatter.
3. Prevent `edgeLabel.formatter` from inheriting series `label.formatter`.
### Fixed issues
- #18729
- #18222
- #18212
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
Please refer to `test/sankey-labelValue.html` and the second test case in `test/pie-label.html`.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18733: fix(sankey): fix `value` is undefined in label/edgeLabel formatter
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18733:
URL: https://github.com/apache/echarts/pull/18733#issuecomment-1589080002
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia merged pull request #18733: fix(sankey): fix `value` is undefined in label/edgeLabel formatter
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #18733:
URL: https://github.com/apache/echarts/pull/18733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on pull request #18733: fix(sankey): fix `value` is undefined in label/edgeLabel formatter
Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on PR #18733:
URL: https://github.com/apache/echarts/pull/18733#issuecomment-1584083025
@adoin How did you test this branch? I can't reproduce the bad case you mentioned.
<img src="https://github.com/apache/echarts/assets/26999792/d8298b3d-0c02-41fb-a506-35360935496a" width="400">
Please use the following commands to get a clean workspace:
```shell
$ git clone -b fix/sankey-label-formatter https://github.com/apache/echarts --depth=1
$ cd echarts
$ npm i
$ npm run dev
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18733: fix(sankey): fix `value` is undefined in label/edgeLabel formatter
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18733:
URL: https://github.com/apache/echarts/pull/18733#issuecomment-1582484680
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org