Re: cvs commit:jakarta-tomcat-connectors/webapp/javaConstants.java.in

["Pier P. Fumagalli" <pi...@betaversion.org>]

jean-frederic clere at jfrederic.clere@fujitsu-siemens.com wrote:

> "Pier P. Fumagalli" wrote:
>> 
>> jean-frederic clere at jfrederic.clere@fujitsu-siemens.com wrote:
>> 
>>> "Pier P. Fumagalli" wrote:
>>>> 
>>>> jfclere@apache.org at jfclere@apache.org wrote:
>>>> 
>>>>> jfclere     01/07/19 07:17:18
>>>>> 
>>>>> Modified:    webapp/java Constants.java.in
>>>>> Log:
>>>>> Add missing Constants.
>>>>> 
>>>>> Revision  Changes    Path
>>>>> 1.2       +8 -0
>>>>> jakarta-tomcat-connectors/webapp/java/Constants.java.in
>>>>> 
>>>>> Index: Constants.java.in
>>>>> ===================================================================
>>>>> RCS file:
>>>>> /home/cvs/jakarta-tomcat-connectors/webapp/java/Constants.java.in,v
>>>>> retrieving revision 1.1
>>>>> retrieving revision 1.2
>>>>> diff -u -r1.1 -r1.2
>>>>> --- Constants.java.in    2001/07/15 08:42:36    1.1
>>>>> +++ Constants.java.in    2001/07/19 14:17:18    1.2
>>>>> @@ -149,4 +149,12 @@
>>>>>       * No payload:<br>
>>>>>       */
>>>>>      public static final int TYPE_CONF_DONE=0x06;
>>>>> +
>>>>> +    /*
>>>>> +     * Added by JFC (please check)
>>>>> +     */
>>>>> +    public static final int TYPE_DISCONNECT=0x07;
>>>>> +    public static final int TYPE_CONF_DEPLOY=0x08;
>>>>> +    public static final int TYPE_CONF_APPLIC=0x09;
>>>>> +    public static final int TYPE_CONF_PROCEED=0x10;
>>>>>  }
>>>> 
>>>> Those are wrong.. :) Me dumb for not updating the Constants.java.in file,
>>>> but only my local copy :)
>>> 
>>> Well I have noted that these were wrong in lib/pr_warp.h we have:
>>> #define TYPE_DISCONNECT   0xfe
>>> #define TYPE_CONF_DEPLOY  0x02
>>> #define TYPE_CONF_APPLIC  0x03
>>> #define TYPE_CONF_DONE    0x04
>>> #define TYPE_CONF_PROCEED 0x05
>>> 
>>> I think the WARP Protocol file needs an update...
>> 
>> Oh _SO_BADLY_... The packet structure changed, packet types changed,
>> multiplexing was dropped (you can't beat the Kernel).... You won't believe
>> :) After the code is stable :)
> 
> That makes harder to help...
> 
> BTW what had happended with warp_handle(), could you commit it? (It says "Not
> yet implemented", would perfer a buggy code...).

Coming... Fixing some bugs due to the new protocol...

    Pier