You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 08:02:58 UTC
[GitHub] [arrow] guyuqi opened a new pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
guyuqi opened a new pull request #12540:
URL: https://github.com/apache/arrow/pull/12540
Add staticcheck for Golang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068873325
Arm64 CI is triggered by travis. Travis will pull the docker image: `arm64v8/golang:1.16-bullseye` which is not built by ourselves. We could not modify docker file to install `staticcheck`.
For this workaround, I added `ARCH ` detect:
```
# Arm64 CI is triggered by travis and run in arm64v8/golang:1.16-bullseye
if [ "aarch64" == "$ARCH" ]; then
# Install `staticcheck`
GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest
fi
```
WDYT? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1070669550
It also doesn't work for removing the @latest.
The original Golang version on Windows MinGW is 1.15.
The golang compile version should match go tool version:
`compile: version "go1.15.5" does not match go tool version "go1.17"`
But when intalling Golang 1.17 on Go by `actions/setup-go@v2` with version 1.17, the Go 1.17.7 was installed by default which also doesn't match go1.17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1071171176
@guyuqi it looks like ming is installing go1.17.1, try using that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1070669550
It also doesn't work for removing the @latest.
The original Golang version on Windows MinGW is 1.15.
The golang compile version should match go tool version:
`compile: version "go1.15.5" does not match go tool version "go1.17"`
But when intalling Golang 1.17 by `actions/setup-go@v2` with version 1.17, the Go 1.17.7 was installed by default which also doesn't match go1.17.
`compile: version "go1.17.7" does not match go tool version "go1.17"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068703853
> @guyuqi Can you add the line `RUN GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest` to the `ci/docker/debian-10-go.dockerfile` and `ci/docker/debian-11-go.dockerfile` and update the go scripts to just reference `staticcheck` directly?
>
> For the Windows CGO situation, i think the issue is that it is pulling in go version 1.17 and we need to run that `go install` command without the manual `GO111MODULE=on` (that need changed with go1.17). So you can add:
>
> ```
> - name: Install staticcheck
> run: go install honnef.co/go/tools/cmd/staticcheck@latest
> ```
>
> to `.github/workflows/go.yml` at line 262 (before running go_build.sh for the windows-mingw workflow)
Sure.
That's informative. I'll update the related files later, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1069173232
@guyuqi I think it works, for the windows mingw one, try removing the `@latest` from the commandline installing staticcheck and see if that fixes the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is Go packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed, but staticcheck failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW)?
`staticcheck` is to check Golang source files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
@zeroshade Really thanks for the suggestion, but unfortunately Installing go1.17.1 also doesn't work.
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is go-packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed from above,
but staticcheck checking failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW) ?
`staticcheck` is to check Golang files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1071171176
@guyuqi it looks like ming is installing go1.17.1, try using that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#discussion_r822901532
##########
File path: ci/scripts/go_build.sh
##########
@@ -21,6 +21,9 @@ set -ex
source_dir=${1}/go
+# Install `staticcheck`
+GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest
+
Review comment:
would it make more sense to add a docker config and make a docker image for this rather than doing the go install here as part of the build/test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068873325
Arm64 CI is triggered by travis. Travis will pull the docker image: `arm64v8/golang:1.16-bullseye` which is not built by ourselves. We could not modify docker file to install `staticcheck`.
For this workaround, I added `ARCH ` detect:
```
ARCH=`uname -m`
# Arm64 CI is triggered by travis and run in arm64v8/golang:1.16-bullseye
if [ "aarch64" == "$ARCH" ]; then
# Install `staticcheck`
GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest
fi
```
WDYT? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is Go packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed, but staticcheck failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW)?
`staticcheck` is to check Golang source files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
@zeroshade Really thanks for the suggestion, but unfortunately Installing go1.17.1 also doesn't work.
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is go-packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed from above,
but staticcheck failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW)?
`staticcheck` is to check Golang source files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
@zeroshade Really thanks for the suggestion, but unfortunately Installing go1.17.1 also doesn't work.
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
maty Go-packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed from above,
but staticcheck failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW)?
`staticcheck` is to check Golang source files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072761008
Thanks much for all this @guyuqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1063178024
@guyuqi I really don't know why the Windows build is failing with that error unless it's somehow using an older version of Go than it should be. I think it might make sense to create a docker image to run staticcheck rather than manually running `go install` in the script. If you need i can provide a Dockerfile for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#discussion_r822903863
##########
File path: go/parquet/file/level_conversion.go
##########
@@ -70,6 +70,7 @@ type LevelInfo struct {
RepeatedAncestorDefLevel int16
}
+//lint:ignore U1000 newDefaultLevelInfo
func newDefaultLevelInfo() *LevelInfo {
return &LevelInfo{NullSlotUsage: 1}
}
Review comment:
if this is unused, just delete it. worst case i can put it back in a future change if it's needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
@zeroshade Really thanks for the suggestion, but unfortunately Installing go1.17.1 also doesn't work.
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is go-packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed from above,
but staticcheck checking failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW) ?
`staticcheck` is to check Golang files which may have been verified on other CI envrionment(windows, Linux , macos).
(May remove `MINGW_LINT: "1"` to enable staticcheck in Windows MinGW in the future)
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1056514582
https://issues.apache.org/jira/browse/ARROW-15296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#discussion_r822902698
##########
File path: go/parquet/file/column_writer.go
##########
@@ -597,6 +597,8 @@ func levelSliceOrNil(rep []int16, offset, batch int64) []int16 {
return rep[offset : batch+offset]
}
+//lint:ignore U1000 maybeReplaceValidity
+//lint:ignore SA1019 ignore deprecated array.Interface
Review comment:
instead of ignoring the deprecated message, might as well update this to be `arrow.Array` instead since you're in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1063647480
> @guyuqi I really don't know why the Windows build is failing with that error unless it's somehow using an older version of Go than it should be. I think it might make sense to create a docker image to run staticcheck rather than manually running `go install` in the script. If you need i can provide a Dockerfile for it
Thanks for your comments.
Removed unused field rather than inserting the `U1000 `lint ignore in the latest commit.
It makes sense to put `staticcheck ` installation into docker images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1063647480
> @guyuqi I really don't know why the Windows build is failing with that error unless it's somehow using an older version of Go than it should be. I think it might make sense to create a docker image to run staticcheck rather than manually running `go install` in the script. If you need i can provide a Dockerfile for it
Thanks for your comments.
Remove unused field rather than inserting the `U1000 `lint ignore.
It makes sense to put `staticcheck ` installation into docker images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072763672
Benchmark runs are scheduled for baseline = 74200f57eb15892f8ff5676db16e078f4406b528 and contender = a7f91ec5565519a3071b90c247564cd97e34e140. a7f91ec5565519a3071b90c247564cd97e34e140 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0e36d19cbbf7440b9777ad5d0cbbcde6...7e81285e54ac4d539b29b9c56bae4263/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e01fddc5e04c432089c7110fb70efe8d...bf45ae2fdaf34107abd6ca6ecfbe9f8b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3082c09c65674cd69d0a8fc62160805b...560ae6ae38da48aabab7f2f817248b33/)
[Finished :arrow_down:0.34% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15aec12df3e346f98adc29989289094e...f54e8b9a923546caadba2660bf308448/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072763672
Benchmark runs are scheduled for baseline = 74200f57eb15892f8ff5676db16e078f4406b528 and contender = a7f91ec5565519a3071b90c247564cd97e34e140. a7f91ec5565519a3071b90c247564cd97e34e140 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0e36d19cbbf7440b9777ad5d0cbbcde6...7e81285e54ac4d539b29b9c56bae4263/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e01fddc5e04c432089c7110fb70efe8d...bf45ae2fdaf34107abd6ca6ecfbe9f8b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3082c09c65674cd69d0a8fc62160805b...560ae6ae38da48aabab7f2f817248b33/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15aec12df3e346f98adc29989289094e...f54e8b9a923546caadba2660bf308448/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1070669550
The original Golang version on Windows MinGW is 1.15.
The golang compile version should match go tool version:
`compile: version "go1.15.5" does not match go tool version "go1.17"`
Intall Golang 1.17 on `WIndows MinGW-CGO` as `Windows 2019 Go 1.16` did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072116843
@zeroshade Really thanks for the suggestion, but unfortunately Installing go1.17.1 also doesn't work.
1. The root cause for `compile: version "go1.17.7" does not match go tool version "go1.17"`
is go-packages conflict：
`mingw-w64-x86_64-go-1.17-1` would be installed by `msys2_setup.sh` and `mingw-w64-x86_64-go-1.17-1` seems incompatible with staticcheck.
So removed `mingw-w64-x86_64-go-1.17-1` installation from `msys2_setup.sh` and install Go by `actions/setup-go@v2`.
2. `staticcheck ` package was successfully installed from above,
but staticcheck failed in MinGW (https://github.com/apache/arrow/runs/5595693539?check_suite_focus=true) :
```
+ 'C:\Users\runneradmin\go/bin/staticcheck' ./...
-: cannot import "gonum.org/v1/gonum/blas" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/cpu" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/goos" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "internal/unsafeheader" (unknown iexport format version 2), export data is newer version - update tool (compile)
-: cannot import "math/bits" (unknown iexport format version 2), export data is newer version - update tool (compile)
```
From https://github.com/google/pprof/issues/662 and https://github.com/dominikh/go-tools/issues/1107, `staticcheck` does not support `Go tip` compiler.
I'm confuesd why the same issues occurred in `MinGW` environment with `Go `not `Gotip` compiler.
( May be environment dependencies ?)
How about skipping `staticcheck` in this tricky environment(MinGW) ?
`staticcheck` is to check Golang files which may have been verified on other CI envrionment(windows, Linux , macos).
```
....
...
env:
MINGW_LINT: "1"
......
...
# Go static check (skipped in MinGW)
if [[ -z "${MINGW_LINT}" ]]; then
pushd ${source_dir}
"$(go env GOPATH)"/bin/staticcheck ./...
popd
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #12540:
URL: https://github.com/apache/arrow/pull/12540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072763672
Benchmark runs are scheduled for baseline = 74200f57eb15892f8ff5676db16e078f4406b528 and contender = a7f91ec5565519a3071b90c247564cd97e34e140. a7f91ec5565519a3071b90c247564cd97e34e140 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0e36d19cbbf7440b9777ad5d0cbbcde6...7e81285e54ac4d539b29b9c56bae4263/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e01fddc5e04c432089c7110fb70efe8d...bf45ae2fdaf34107abd6ca6ecfbe9f8b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3082c09c65674cd69d0a8fc62160805b...560ae6ae38da48aabab7f2f817248b33/)
[Finished :arrow_down:0.34% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15aec12df3e346f98adc29989289094e...f54e8b9a923546caadba2660bf308448/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068873325
Arm64 CI is triggered by travis. Travis will pull the docker image: `arm64v8/golang:1.16-bullseye` which is not built by ourselves. We could not modify docker file to install `staticcheck`.
For this workaround, I added `ARCH ` detect:
```
+# Arm64 CI is triggered by travis and run in arm64v8/golang:1.16-bullseye
if [ "aarch64" == "$ARCH" ]; then
# Install `staticcheck`
GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1061571960
As talked in PR https://github.com/apache/arrow/pull/12074, add staticcheck and fix the related lint issues. @zeroshade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#discussion_r822903091
##########
File path: go/parquet/file/column_writer_test.go
##########
@@ -222,6 +222,7 @@ type PrimitiveWriterTestSuite struct {
metadata *metadata.ColumnChunkMetaDataBuilder
sink *encoding.BufferWriter
readbuffer *memory.Buffer
+ //lint:ignore U1000 reader
reader file.ColumnChunkReader
Review comment:
if this isn't being used in the tests we can just remove this rather than having the lint ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068702544
@guyuqi Can you add the line `RUN GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest` to the `ci/docker/debian-10-go.dockerfile` and `ci/docker/debian-11-go.dockerfile` and update the go scripts to just reference `staticcheck` directly?
For the Windows CGO situation, i think the issue is that it is pulling in go version 1.17 and we need to run that `go install` command without the manual `GO111MODULE=on` (that need changed with go1.17). So you can add:
```
- name: Install staticcheck
run: go install honnef.co/go/tools/cmd/staticcheck@latest
```
to `.github/workflows/go.yml` at line 262 (before running go_build.sh for the windows-mingw workflow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1068873325
Arm64 CI is triggered by travis. Travis will pull the docker image: `arm64v8/golang:1.16-bullseye` which is not built by ourselves. We could not modify docker file to install `staticcheck`.
For this workaround, I added `ARCH ` detect:
```
+# Arm64 CI is triggered by travis and run in arm64v8/golang:1.16-bullseye
if [ "aarch64" == "$ARCH" ]; then
# Install `staticcheck`
GO111MODULE=on go install honnef.co/go/tools/cmd/staticcheck@latest
fi
```
WDYT? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1072763672
Benchmark runs are scheduled for baseline = 74200f57eb15892f8ff5676db16e078f4406b528 and contender = a7f91ec5565519a3071b90c247564cd97e34e140. a7f91ec5565519a3071b90c247564cd97e34e140 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0e36d19cbbf7440b9777ad5d0cbbcde6...7e81285e54ac4d539b29b9c56bae4263/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e01fddc5e04c432089c7110fb70efe8d...bf45ae2fdaf34107abd6ca6ecfbe9f8b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3082c09c65674cd69d0a8fc62160805b...560ae6ae38da48aabab7f2f817248b33/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15aec12df3e346f98adc29989289094e...f54e8b9a923546caadba2660bf308448/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] guyuqi commented on pull request #12540: ARROW-15296: [CI][GO] Add Go staticcheck linting to CI lint job
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #12540:
URL: https://github.com/apache/arrow/pull/12540#issuecomment-1057626513
There are some staticcheck issues（SA1019, U1000) on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org