You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/23 00:21:26 UTC
Review Request 64823: Documented the change in the Protobuf
requirement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64823/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang.
Repository: mesos
Description
-------
Documented the change in the Protobuf requirement.
Diffs
-----
CHANGELOG 179b53b0568e4d993553f5cdb13668d96aa400d0
docs/upgrades.md f2eb5a94d67b44a02d355981a673bd4ef5129653
Diff: https://reviews.apache.org/r/64823/diff/1/
Testing
-------
N/A
The requirement is checked in https://reviews.apache.org/r/64822/.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64823: Documented the change in the Protobuf
requirement.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64823/#review195552
-----------------------------------------------------------
Fix it, then Ship it!
Let's make sure to land this in `1.5.0-rc1` in addition to `master`.
CHANGELOG
Lines 14 (patched)
<https://reviews.apache.org/r/64823/#comment274787>
I'd move this section to the bottom. Maybe we could use a more generic title, e.g., `Changes to dependencies`.
- Benjamin Bannier
On Dec. 23, 2017, 1:21 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64823/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 1:21 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented the change in the Protobuf requirement.
>
>
> Diffs
> -----
>
> CHANGELOG 179b53b0568e4d993553f5cdb13668d96aa400d0
> docs/upgrades.md f2eb5a94d67b44a02d355981a673bd4ef5129653
>
>
> Diff: https://reviews.apache.org/r/64823/diff/1/
>
>
> Testing
> -------
>
> N/A
>
> The requirement is checked in https://reviews.apache.org/r/64822/.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64823: Documented the change in the Protobuf
requirement.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64823/#review195556
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64823`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64823
Relevant logs:
- [apply-review-64823-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64823/logs/apply-review-64823-stdout.log):
```
error: patch failed: CHANGELOG:11
error: CHANGELOG: patch does not apply
error: patch failed: docs/upgrades.md:51
error: docs/upgrades.md: patch does not apply
```
- Mesos Reviewbot Windows
On Dec. 23, 2017, 12:21 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64823/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2017, 12:21 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented the change in the Protobuf requirement.
>
>
> Diffs
> -----
>
> CHANGELOG 179b53b0568e4d993553f5cdb13668d96aa400d0
> docs/upgrades.md f2eb5a94d67b44a02d355981a673bd4ef5129653
>
>
> Diff: https://reviews.apache.org/r/64823/diff/1/
>
>
> Testing
> -------
>
> N/A
>
> The requirement is checked in https://reviews.apache.org/r/64822/.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>