You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Lieven Govaerts <sv...@mobsol.be> on 2012/09/01 11:36:28 UTC
Re: [PATCH] subversion issue #4174 - serf: checkout / export over
https errors out with "svn: E730053: Error retrieving REPORT (730053)"
Johan,
On Mon, Aug 27, 2012 at 9:15 PM, Johan Corveleyn <jc...@gmail.com> wrote:
> On Mon, Aug 27, 2012 at 8:48 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>> Hi Johan,
>>
>> On Mon, Aug 27, 2012 at 2:44 PM, Johan Corveleyn <jc...@gmail.com> wrote:
>>> On Mon, Aug 20, 2012 at 12:43 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>>>> On Mon, Aug 20, 2012 at 10:18 AM, Johan Corveleyn <jc...@gmail.com> wrote:
>>>>> On Sun, Aug 19, 2012 at 1:53 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>>>>>> Hi Johan,
>>>>>>
>>>>>>
>>>>>> as you seem to be the only one encountering issue 4174, would you mind
>>>>>> testing attached serf patch?
>>>>>> You'll have to update serf trunk to r1627 to apply it cleanly.
>>>>>>
>>>>>> It fixes the issue for me on Windows 7 with svn trunk and serf trunk.
>>>>>> While I have tested the patches on Mac OS X too, I couldn't reproduce
>>>>>> the original problem.
>>>>>
>>>>> Great, it works!
>>>>>
>>>>> - svn trunk@1374802 with serf trunk@1627 without patch: verified that
>>>>> I could still reproduce the original issue.
>>>>>
>>>>> - svn trunk@1374802 with serf trunk@1627 with your patch: the issue
>>>>> did not occur anymore. I could successfully export the dreaded large
>>>>> working copy from our repository over https. I tried a couple of times
>>>>> to be sure, and there was no problem anymore.
>>>>>
>>>>
>>>> Okay, thanks for testing! I've committed the fix in serf r1628.
>>>
>>> Hi Lieven,
>>>
>>> I'm afraid the issue may not be completely fixed yet. After further
>>> testing with even larger exports and checkouts, I again got the same
>>> error:
>>>
>>> [[[
>>> C:\Temp\svnperf>timeit svn export https://playsvn/svn/testrepo/trunk
>>> trunk-exp10 -q
>>> svn: E730053: Error retrieving REPORT (730053): An established
>>> connection was aborted by the software in your host machine.
>>> start: 2012-27-08 14:22:02,88
>>> end : 2012-27-08 14:24:59,70
>>> total runtime: 176820 ms
>>> ]]]
>>>
>>> This export should yield 87064 files in 12849 directories. The one
>>> above errored out after 17343 files and 2878 dirs.
>>>
>>> But it's much harder to reproduce now (unfortunately): often the
>>> export will complete just fine. It may be related to network
>>> conditions: yesterday during the day I first ran into this. Then late
>>> at night I tried for hours to reproduce it again, but no errors
>>> anymore. Today during the day (with more traffic going on) tried
>>> again, and got the error again.
>>>
>>> Can you take another look for similar problems, other error conditions
>>> of the same nature, ... ?
>>>
..
>>
>> So I'm working on a patch that handles connection aborts and resets
>> correctly. My work in progress already handles these correctly,
>> however I've run into a memory corruption when resending a PROPFIND
>> request, so I'd like to fix that first.
>>
serf trunk r1634 should solve the connection aborts and other errors
you have been seeing on large checkouts over https.
Can you use this latest rev. and let me know if you still encounter
these issues?
thanks,
Lieven
Re: [PATCH] subversion issue #4174 - serf: checkout / export over
https errors out with "svn: E730053: Error retrieving REPORT (730053)"
Posted by Johan Corveleyn <jc...@gmail.com>.
On Mon, Sep 3, 2012 at 9:21 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
> On Mon, Sep 3, 2012 at 10:55 AM, Johan Corveleyn <jc...@gmail.com> wrote:
>> Hi Lieven,
>>
>> When I run with svn-trunk@1377016 with serf-trunk@1634, I get the
>> following error pretty quickly (after a hundred files or so (but not
>> always the same one)):
>>
>> [[[
>> svn: E120171: Error retrieving REPORT (120171): APR does not
>> understand this error code
>> ]]]
>>
>> FWIW, I compiled with apr-1.4.5 and apr-util-1.3.12 (actually what's
>> included with httpd 2.2.19)
>>
>> But when I run the same svn version with serf-trunk@1633 (I read in
>> your log message from r1634 that you did something with handling
>> errors on Windows, so I gave 1633 a try as well), it works flawlessly
>> (so far I did 4 large exports and 1 really huge export without
>> problems).
>>
>> So it seems we're almost there :-). Or maybe I'm testing the wrong
>> revision, or should I cherrypick a couple specific revisions to
>> serf-1.1.x?
>>
>
> r1634 has a quite obvious copy-paste error, which I missed during
> testing because the issue doesn't occur always for me. This has been
> fixed in r1637, so it should now have the intended behavior.
Seem I now get (actually as of r1635):
[[[
buckets\ssl_buckets.c(206): error C2169: 'log' : intrinsic function,
cannot be defined
[C:\research\svn\client_build\svn_deps\serf-trunk\serf.vcxproj]
]]]
Seems that function needs to be renamed.
--
Johan
Re: [PATCH] subversion issue #4174 - serf: checkout / export over
https errors out with "svn: E730053: Error retrieving REPORT (730053)"
Posted by Lieven Govaerts <sv...@mobsol.be>.
On Mon, Sep 3, 2012 at 10:55 AM, Johan Corveleyn <jc...@gmail.com> wrote:
> Hi Lieven,
>
> When I run with svn-trunk@1377016 with serf-trunk@1634, I get the
> following error pretty quickly (after a hundred files or so (but not
> always the same one)):
>
> [[[
> svn: E120171: Error retrieving REPORT (120171): APR does not
> understand this error code
> ]]]
>
> FWIW, I compiled with apr-1.4.5 and apr-util-1.3.12 (actually what's
> included with httpd 2.2.19)
>
> But when I run the same svn version with serf-trunk@1633 (I read in
> your log message from r1634 that you did something with handling
> errors on Windows, so I gave 1633 a try as well), it works flawlessly
> (so far I did 4 large exports and 1 really huge export without
> problems).
>
> So it seems we're almost there :-). Or maybe I'm testing the wrong
> revision, or should I cherrypick a couple specific revisions to
> serf-1.1.x?
>
r1634 has a quite obvious copy-paste error, which I missed during
testing because the issue doesn't occur always for me. This has been
fixed in r1637, so it should now have the intended behavior.
> --
> Johan
Lieven
Re: [PATCH] subversion issue #4174 - serf: checkout / export over
https errors out with "svn: E730053: Error retrieving REPORT (730053)"
Posted by Johan Corveleyn <jc...@gmail.com>.
On Sat, Sep 1, 2012 at 11:36 AM, Lieven Govaerts <sv...@mobsol.be> wrote:
> Johan,
>
> On Mon, Aug 27, 2012 at 9:15 PM, Johan Corveleyn <jc...@gmail.com> wrote:
>> On Mon, Aug 27, 2012 at 8:48 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>>> Hi Johan,
>>>
>>> On Mon, Aug 27, 2012 at 2:44 PM, Johan Corveleyn <jc...@gmail.com> wrote:
>>>> On Mon, Aug 20, 2012 at 12:43 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>>>>> On Mon, Aug 20, 2012 at 10:18 AM, Johan Corveleyn <jc...@gmail.com> wrote:
>>>>>> On Sun, Aug 19, 2012 at 1:53 PM, Lieven Govaerts <sv...@mobsol.be> wrote:
>>>>>>> Hi Johan,
>>>>>>>
>>>>>>>
>>>>>>> as you seem to be the only one encountering issue 4174, would you mind
>>>>>>> testing attached serf patch?
>>>>>>> You'll have to update serf trunk to r1627 to apply it cleanly.
>>>>>>>
>>>>>>> It fixes the issue for me on Windows 7 with svn trunk and serf trunk.
>>>>>>> While I have tested the patches on Mac OS X too, I couldn't reproduce
>>>>>>> the original problem.
>>>>>>
>>>>>> Great, it works!
>>>>>>
>>>>>> - svn trunk@1374802 with serf trunk@1627 without patch: verified that
>>>>>> I could still reproduce the original issue.
>>>>>>
>>>>>> - svn trunk@1374802 with serf trunk@1627 with your patch: the issue
>>>>>> did not occur anymore. I could successfully export the dreaded large
>>>>>> working copy from our repository over https. I tried a couple of times
>>>>>> to be sure, and there was no problem anymore.
>>>>>>
>>>>>
>>>>> Okay, thanks for testing! I've committed the fix in serf r1628.
>>>>
>>>> Hi Lieven,
>>>>
>>>> I'm afraid the issue may not be completely fixed yet. After further
>>>> testing with even larger exports and checkouts, I again got the same
>>>> error:
>>>>
>>>> [[[
>>>> C:\Temp\svnperf>timeit svn export https://playsvn/svn/testrepo/trunk
>>>> trunk-exp10 -q
>>>> svn: E730053: Error retrieving REPORT (730053): An established
>>>> connection was aborted by the software in your host machine.
>>>> start: 2012-27-08 14:22:02,88
>>>> end : 2012-27-08 14:24:59,70
>>>> total runtime: 176820 ms
>>>> ]]]
>>>>
>>>> This export should yield 87064 files in 12849 directories. The one
>>>> above errored out after 17343 files and 2878 dirs.
>>>>
>>>> But it's much harder to reproduce now (unfortunately): often the
>>>> export will complete just fine. It may be related to network
>>>> conditions: yesterday during the day I first ran into this. Then late
>>>> at night I tried for hours to reproduce it again, but no errors
>>>> anymore. Today during the day (with more traffic going on) tried
>>>> again, and got the error again.
>>>>
>>>> Can you take another look for similar problems, other error conditions
>>>> of the same nature, ... ?
>>>>
> ..
>>>
>>> So I'm working on a patch that handles connection aborts and resets
>>> correctly. My work in progress already handles these correctly,
>>> however I've run into a memory corruption when resending a PROPFIND
>>> request, so I'd like to fix that first.
>>>
>
> serf trunk r1634 should solve the connection aborts and other errors
> you have been seeing on large checkouts over https.
> Can you use this latest rev. and let me know if you still encounter
> these issues?
Hi Lieven,
When I run with svn-trunk@1377016 with serf-trunk@1634, I get the
following error pretty quickly (after a hundred files or so (but not
always the same one)):
[[[
svn: E120171: Error retrieving REPORT (120171): APR does not
understand this error code
]]]
FWIW, I compiled with apr-1.4.5 and apr-util-1.3.12 (actually what's
included with httpd 2.2.19)
But when I run the same svn version with serf-trunk@1633 (I read in
your log message from r1634 that you did something with handling
errors on Windows, so I gave 1633 a try as well), it works flawlessly
(so far I did 4 large exports and 1 really huge export without
problems).
So it seems we're almost there :-). Or maybe I'm testing the wrong
revision, or should I cherrypick a couple specific revisions to
serf-1.1.x?
--
Johan