[jira] [Commented] (PARQUET-2043) Fail build for used but not declared direct dependencies

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414714#comment-17414714 ] 

ASF GitHub Bot commented on PARQUET-2043:
-----------------------------------------

shangxinli opened a new pull request #932:
URL: https://github.com/apache/parquet-mr/pull/932


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fail build for used but not declared direct dependencies
> --------------------------------------------------------
>
>                 Key: PARQUET-2043
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2043
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Gabor Szadovszky
>            Assignee: Gabor Szadovszky
>            Priority: Major
>
> It is always a good practice to specify all the dependencies directly used (classes are imported from) by our modules. We have a couple of issues where classes are imported from transitive dependencies. It makes hard to validate the actual dependency tree and also may result in using wrong versions of classes (see PARQUET-2038 for example).
> It would be good to enforce to reference such dependencies directly in the module poms. The [maven-dependency-plugin analyze-only goal|http://maven.apache.org/plugins/maven-dependency-plugin/analyze-only-mojo.html] can be used for this purpose.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)