You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/04/11 10:08:33 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4692: Set Maven Resolver Transport connection timeout to 6000ms
bowenliang123 opened a new pull request, #4692:
URL: https://github.com/apache/kyuubi/pull/4692
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- “the default transport in Maven 3.9.0+ is NOT Wagon anymore. ” (https://maven.apache.org/guides/mini/guide-http-settings.html)
- ""
-
https://github.com/apache/maven-wagon/blob/master/wagon-provider-api/src/main/java/org/apache/maven/wagon/Wagon.java#L44
wagon's default connect timeout is 60000ms (1min)
- https://maven.apache.org/resolver/configuration.html
Resolver Transport's default connection timeout: 10000ms (10sec)
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163697834
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
introduce a `settings.xml` looks too complex for new developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163713489
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
It seems Wagon also requires settings.xml if we need to set connection timeout.
https://maven.apache.org/guides/mini/guide-http-settings.html#connection-timeouts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4692: Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#issuecomment-1503080690
cc @yaooqinn @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] LuciferYang commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163713692
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
Will `wagon ` be removed? back to `wagon ` looks simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] LuciferYang commented on a diff in pull request #4692: Increase Maven Resolver Transport connection timeout
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1162720275
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
I am not familiar with this property, I want to know if it can be placed in `MVN_OPT` as `-Daether.connector.connectTimeout=60000` or can it be configured in `pom.xml`? thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] LuciferYang commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163717510
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
<img width="596" alt="image" src="https://user-images.githubusercontent.com/1475305/231379851-6d6be5ae-429f-4040-863a-d9ad5d885d2c.png">
@bowenliang123 As you said, `Wagon's default connect timeout is 60000ms (1min)`, Do we still need to increase it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163805731
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
Not sure about this. @LuciferYang
And according to @cxzl25 's advice, we are trying to switch to use Wagon in #4699 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4692: Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#issuecomment-1503264427
Still unstable, let me try to move the config to pom's property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1162747171
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
Not sure about this. All I found is "To set one of the configuration options from above just use system variables. " mentioned in the description of this PR. But as you see some tests still failed when resolving dependencies, it seems that setting it here in the system env variable does not help. I would like to see what happens when you are doing setting it via property in pom in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163706648
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
The introduced `settings.xml` is now only used and auto-applied in CI builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163693320
##########
.github/maven/settings.xml:
##########
@@ -0,0 +1,12 @@
+<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
+ <servers>
+ <server>
+ <id>gcs-maven-central-mirror</id>
+ <configuration>
+ <aether.connector.connectTimeout>60000</aether.connector.connectTimeout>
Review Comment:
Let's try this. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163453722
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
I think there's a possible way to config this option in `settings/servers/server/configuration` via `settings.xml` of Maven. see: https://maven.apache.org/settings.html#servers
```
<settings>
<servers>
<server>
<id>repoid</id>
<configuration></configuration>
</server>
</servers>
...
</settings>
```
But I don't know how to do it in CI builds.
@LuciferYang
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
I think there's a possible way to config this option in `settings/servers/server/configuration` via `settings.xml` of Maven. see: https://maven.apache.org/settings.html#servers
```
<settings>
<servers>
<server>
<id>repoid</id>
<configuration></configuration>
</server>
</servers>
...
</settings>
```
But I don't know how to do it in CI builds.
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163453722
##########
.github/workflows/master.yml:
##########
@@ -35,6 +35,7 @@ env:
MVN_OPT: -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded -Dmaven.plugin.download.cache.path=/tmp/engine-archives
KUBERNETES_VERSION: v1.26.1
MINIKUBE_VERSION: v1.29.0
+ "aether.connector.connectTimeout": 60000
Review Comment:
I think there's a possible way to config this option in `settings/servers/server/configuration` via `settings.xml` of Maven. see: https://maven.apache.org/settings.html#servers
```
<settings>
<servers>
<server>
<id>repoid</id>
<configuration></configuration>
</server>
</servers>
...
</settings>
```
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] LuciferYang commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163715064
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
The default timeout of `wagon` also changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#discussion_r1163666880
##########
.github/maven/settings.xml:
##########
@@ -0,0 +1,12 @@
+<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
+ <servers>
+ <server>
+ <id>gcs-maven-central-mirror</id>
+ <configuration>
+ <aether.connector.connectTimeout>60000</aether.connector.connectTimeout>
Review Comment:
```xml
<connectTimeout>60000</connectTimeout>
```
https://maven.apache.org/guides/mini/guide-resolver-transport.html#timeouts
##########
build/mvn:
##########
@@ -25,7 +25,7 @@ _CALLING_DIR="$(pwd)"
_COMPILE_JVM_OPTS="-Xms2g -Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
if [ "$CI" ]; then
- export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast"
+ export MAVEN_CLI_OPTS="--no-transfer-progress --errors --fail-fast --settings ${GITHUB_WORKSPACE}/.github/maven/settings.xml"
Review Comment:
```
-Dmaven.resolver.transport=wagon
```
https://maven.apache.org/guides/mini/guide-resolver-transport.html#how-to-upgrade-from-wagon-or-%E2%80%9Cnative-transport-does-not-work%E2%80%9D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#issuecomment-1504765461
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4692?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4692](https://codecov.io/gh/apache/kyuubi/pull/4692?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (847794f) into [master](https://codecov.io/gh/apache/kyuubi/commit/f0615a9aab0a5b755c16ee0b966a5ea59b98bd10?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0615a9) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 847794f differs from pull request most recent head 9175697. Consider uploading reports for the commit 9175697 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4692 +/- ##
============================================
- Coverage 57.99% 57.88% -0.11%
Complexity 13 13
============================================
Files 580 580
Lines 32218 32218
Branches 4304 4304
============================================
- Hits 18684 18650 -34
- Misses 11749 11775 +26
- Partials 1785 1793 +8
```
[see 11 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4692/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
URL: https://github.com/apache/kyuubi/pull/4692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4692: [INFRA] Increase Maven Resolver Transport connection timeout
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4692:
URL: https://github.com/apache/kyuubi/pull/4692#issuecomment-1506628166
Closing this PR. Leave as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org