You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2007/07/30 06:57:13 UTC

[jira] Created: (MRM-436) incorrect default cron expression for snapshots repository

incorrect default cron expression for snapshots repository
----------------------------------------------------------

                 Key: MRM-436
                 URL: http://jira.codehaus.org/browse/MRM-436
             Project: Archiva
          Issue Type: Bug
    Affects Versions: 1.0-beta-1
            Reporter: Brett Porter


it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Work started: (MRM-436) incorrect default cron expression for snapshots repository

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on MRM-436 started by Maria Odea Ching.

> incorrect default cron expression for snapshots repository
> ----------------------------------------------------------
>
>                 Key: MRM-436
>                 URL: http://jira.codehaus.org/browse/MRM-436
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-1
>            Reporter: Brett Porter
>            Assignee: Maria Odea Ching
>             Fix For: 1.0-beta-2
>
>
> it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-436) incorrect default cron expression for snapshots repository

Posted by "Joakim Erdfelt (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joakim Erdfelt updated MRM-436:
-------------------------------

    Fix Version/s: 1.0-beta-2

> incorrect default cron expression for snapshots repository
> ----------------------------------------------------------
>
>                 Key: MRM-436
>                 URL: http://jira.codehaus.org/browse/MRM-436
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-1
>            Reporter: Brett Porter
>             Fix For: 1.0-beta-2
>
>
> it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-436) incorrect default cron expression for snapshots repository

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching closed MRM-436.
--------------------------------

    Resolution: Fixed

Fixed in -r566945

Fix:
- Added '\' for the snapshots cron expression in default-archiva.xml to escape the ',' 
- (DefaultArchivaConfiguration) Added method for adding '\' to the cron expression if ',' exists before saving the configuration and method for 
removing '\' after the configuration is read from the configuration file




> incorrect default cron expression for snapshots repository
> ----------------------------------------------------------
>
>                 Key: MRM-436
>                 URL: http://jira.codehaus.org/browse/MRM-436
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-1
>            Reporter: Brett Porter
>            Assignee: Maria Odea Ching
>             Fix For: 1.0-beta-2
>
>
> it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-436) incorrect default cron expression for snapshots repository

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104779 ] 

Brett Porter commented on MRM-436:
----------------------------------

oh good catch. You are right, the registry reader thinks it is a list (which it shouldn't do if the type isn't a list...)

I think we need to make it possible to store the commas, either by fixing the registry reader, or escaping it in some way before interacting with the registry in the configuration.

> incorrect default cron expression for snapshots repository
> ----------------------------------------------------------
>
>                 Key: MRM-436
>                 URL: http://jira.codehaus.org/browse/MRM-436
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-1
>            Reporter: Brett Porter
>            Assignee: Maria Odea Ching
>             Fix For: 1.0-beta-2
>
>
> it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-436) incorrect default cron expression for snapshots repository

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104778 ] 

Maria Odea Ching commented on MRM-436:
--------------------------------------

Assuming that I don't have archiva.xml in ~/.m2/, so the one in $ARCHIVA_BASE$/conf/ (which initially just contains an empty <configuration/>) is used..

The default-archiva.xml has '0 0,30 0 * * ?' as the default cron expression for the snapshots repository. But it becomes '0 0' when displayed in the repositories page in archiva-webapp. When I updated the snapshots repository config and set the cron expression to '0 0,30 0 * * ?', I saw that there became two cron expression entries in its configuration in archiva.xml <refreshCronExpression>0 0</refreshCronExpression> and <refreshCronExpression>30 0 * * ?</refreshCronExpression>.  Although this is the case, the cron expression displayed in the webapp is still corrent, which is '0 0,30 0 * * ?'.

I suspect that the RegistryReader and RegistryWriter handles it as a special case when a ',' (comma) is recognized. 

There are two ways to approach this:
1. Set the default expression for the snapshots repo to be the same as for the releases
2. Set 2 <refreshCronExpression> values in default-archiva.xml for the snapshots repository <refreshCronExpression>0 0</refreshCronExpression>  and <refreshCronExpression>30 0 * * ?</refreshCronExpression>.

I'll do the first one for now as this was what has been suggested above :)



> incorrect default cron expression for snapshots repository
> ----------------------------------------------------------
>
>                 Key: MRM-436
>                 URL: http://jira.codehaus.org/browse/MRM-436
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0-beta-1
>            Reporter: Brett Porter
>            Assignee: Maria Odea Ching
>             Fix For: 1.0-beta-2
>
>
> it is '0 0' which is not a valid value - it should probably be the same as for releases

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira