You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2019/04/11 18:45:00 UTC
[jira] [Resolved] (SPARK-27404) Fix build warnings for 3.0:
postfixOps edition
[ https://issues.apache.org/jira/browse/SPARK-27404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved SPARK-27404.
-------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Issue resolved by pull request 24314
[https://github.com/apache/spark/pull/24314]
> Fix build warnings for 3.0: postfixOps edition
> ----------------------------------------------
>
> Key: SPARK-27404
> URL: https://issues.apache.org/jira/browse/SPARK-27404
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core, SQL, Structured Streaming, YARN
> Affects Versions: 3.0.0
> Reporter: Sean Owen
> Assignee: Sean Owen
> Priority: Minor
> Fix For: 3.0.0
>
>
> I'd like to fix various build warnings showing in the build right now -- see the upcoming PR for details as they are varied and small.
> However while fixing warnings about use of postfix notation (i.e. "foo bar" instead of "foo.bar"), I'd like to just remove use of postfix entirely to standardize. They aren't deprecated exactly, but seemed to be frowned upon as usually adding more confusion than clarify (https://contributors.scala-lang.org/t/lets-drop-postfix-operators/1457) and have to be enabled by importing scala.language.postfixOps to avoid warnings.
> I find that use of scalatest postfix syntax doesn't cause warnings, and that's normal usage for scalatest, so will leave that. "0 until n" syntax also doesn't trigger the warnings, it seems. But things like "10 seconds" do, and can be "10.seconds".
> Part of the reason I went ahead in changing that is that we have many instances of things like "120000 milliseconds" in the code, which are simpler as "2.minutes" anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org