You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "unixzii (via GitHub)" <gi...@apache.org> on 2023/06/26 09:09:45 UTC
[GitHub] [incubator-opendal] unixzii opened a new pull request, #2545: ci(bindings/swift): optimize time consumption of CI pipeline
unixzii opened a new pull request, #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545
Fixes #2542.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1241955813
##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
DIRS=$(INCLUDE_DIR) $(LIB_DIR)
+CARGO_FLAGS=--release
Review Comment:
You are right. But there is no need for a release build (since we are not ready for the first release). So how about removing them for now and only add while needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1241955813
##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
DIRS=$(INCLUDE_DIR) $(LIB_DIR)
+CARGO_FLAGS=--release
Review Comment:
You are right. But there is no need for a release build (since we are not ready for the first release). So how about removing them for now and only add while needed? It's Ok to hardcoded here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1241879419
##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
DIRS=$(INCLUDE_DIR) $(LIB_DIR)
+CARGO_FLAGS=--release
Review Comment:
I prefer to keep makefiles as simple as possible and avoid using many arguments. When necessary, I would rather write a new `release` target instead of maintaining complex makefiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] unixzii commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "unixzii (via GitHub)" <gi...@apache.org>.
unixzii commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1241944331
##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
DIRS=$(INCLUDE_DIR) $(LIB_DIR)
+CARGO_FLAGS=--release
Review Comment:
Creating repetitive rules can make it harder to maintain (we need to update them both when there are some changes), and it's also why variables exist in Makefiles. I don't think keeping simplicity in this way is necessary in this scenario, since it won't bring too many understanding difficulties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] unixzii commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline
Posted by "unixzii (via GitHub)" <gi...@apache.org>.
unixzii commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1242047844
##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
DIRS=$(INCLUDE_DIR) $(LIB_DIR)
+CARGO_FLAGS=--release
Review Comment:
It’s ok for me, and let me track it in the main issue. It needs to be fixed before releasing because users definitely don’t want to depend on a debug package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org