You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "zhijiang (Jira)" <ji...@apache.org> on 2019/12/31 07:24:00 UTC

[jira] [Created] (FLINK-15444) Make the component AbstractInvokable in CheckpointBarrierHandler NonNull

zhijiang created FLINK-15444:
--------------------------------

             Summary: Make the component AbstractInvokable in CheckpointBarrierHandler NonNull 
                 Key: FLINK-15444
                 URL: https://issues.apache.org/jira/browse/FLINK-15444
             Project: Flink
          Issue Type: Task
          Components: Runtime / Checkpointing
            Reporter: zhijiang
            Assignee: zhijiang


The current component {{AbstractInvokable}} in {{CheckpointBarrierHandler}} is annotated as {{@Nullable}}. Actually in real code path it is passed via the constructor and never be null. The nullable annotation is only used for unit test purpose. But this way would mislead the real usage in practice and bring extra troubles, because you have to alway check whether it is null before usage in related processes.

We can refactor the related unit tests to implement a dummy {{AbstractInvokable}} for tests and remove the {{@Nullable}} annotation from the related class constructors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)