You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jamie goodyear (JIRA)" <ji...@apache.org> on 2009/04/29 21:31:30 UTC
[jira] Created: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Allow osgi/stop command to specify more than one bundle per command entry.
--------------------------------------------------------------------------
Key: FELIX-1104
URL: https://issues.apache.org/jira/browse/FELIX-1104
Project: Felix
Issue Type: Improvement
Components: Karaf
Environment: Linux
Reporter: Jamie goodyear
Allow osgi/stop command to specify more than one bundle per command entry.
Encountered during SMX Kernel usage:
smx@root:osgi> stop 180 177 176 173
ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reassigned FELIX-1104:
--------------------------------------
Assignee: Guillaume Nodet
> Allow osgi/stop command to specify more than one bundle per command entry.
> --------------------------------------------------------------------------
>
> Key: FELIX-1104
> URL: https://issues.apache.org/jira/browse/FELIX-1104
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Environment: Linux
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Attachments: FELIX-1104-2.txt, FELIX-1104.txt
>
>
> Allow osgi/stop command to specify more than one bundle per command entry.
> Encountered during SMX Kernel usage:
> smx@root:osgi> stop 180 177 176 173
> ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
> In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filippo Diotalevi updated FELIX-1104:
-------------------------------------
Attachment: FELIX-1104-2.txt
Second patch with improved formatting.
> Allow osgi/stop command to specify more than one bundle per command entry.
> --------------------------------------------------------------------------
>
> Key: FELIX-1104
> URL: https://issues.apache.org/jira/browse/FELIX-1104
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Environment: Linux
> Reporter: Jamie goodyear
> Attachments: FELIX-1104-2.txt, FELIX-1104.txt
>
>
> Allow osgi/stop command to specify more than one bundle per command entry.
> Encountered during SMX Kernel usage:
> smx@root:osgi> stop 180 177 176 173
> ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
> In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-1104.
------------------------------------
Resolution: Fixed
Fix Version/s: karaf-1.0.0
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/BundleCommand.java
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/BundlesCommand.java
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/RestartBundle.java
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/StartBundle.java
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/StopBundle.java
Sending gshell/gshell-osgi/src/main/java/org/apache/servicemix/kernel/gshell/osgi/Util.java
Transmitting file data ......
Committed revision 770318.
Slightly refactored patch to move most of the logic into the BundlesCommand
> Allow osgi/stop command to specify more than one bundle per command entry.
> --------------------------------------------------------------------------
>
> Key: FELIX-1104
> URL: https://issues.apache.org/jira/browse/FELIX-1104
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Environment: Linux
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Fix For: karaf-1.0.0
>
> Attachments: FELIX-1104-2.txt, FELIX-1104.txt
>
>
> Allow osgi/stop command to specify more than one bundle per command entry.
> Encountered during SMX Kernel usage:
> smx@root:osgi> stop 180 177 176 173
> ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
> In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704704#action_12704704 ]
Jamie goodyear commented on FELIX-1104:
---------------------------------------
I agree that we should ask for confirmation before stopping a system bundle. Something I noticed when reading the patch submission is that we are starting to collect a few classes containing '< 50'. It may be a good idea to setup a utility class to hold the system bundle level indicator (maybe add a call to the Util class), it would reduce the occurrence of hard coded numbers in the package.
> Allow osgi/stop command to specify more than one bundle per command entry.
> --------------------------------------------------------------------------
>
> Key: FELIX-1104
> URL: https://issues.apache.org/jira/browse/FELIX-1104
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Environment: Linux
> Reporter: Jamie goodyear
> Assignee: Guillaume Nodet
> Fix For: karaf-1.0.0
>
> Attachments: FELIX-1104-2.txt, FELIX-1104.txt
>
>
> Allow osgi/stop command to specify more than one bundle per command entry.
> Encountered during SMX Kernel usage:
> smx@root:osgi> stop 180 177 176 173
> ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
> In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1104) Allow osgi/stop command to specify
more than one bundle per command entry.
Posted by "Filippo Diotalevi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filippo Diotalevi updated FELIX-1104:
-------------------------------------
Attachment: FELIX-1104.txt
I wanted to maintain the same user experience of the previous stop command, asking the user for confirmation to stop a bundle with startLevel < 50; so I had to do some refactoring.
- BundleCommand.java . extracted logic to check if a bundle is a system bundle and to ask user confirmation
- Util.java added utility methods
- StopCommand.java extends BundleSCommand instead of BundleCommand. added code to ask user confirmation to stop system bundles
> Allow osgi/stop command to specify more than one bundle per command entry.
> --------------------------------------------------------------------------
>
> Key: FELIX-1104
> URL: https://issues.apache.org/jira/browse/FELIX-1104
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Environment: Linux
> Reporter: Jamie goodyear
> Attachments: FELIX-1104.txt
>
>
> Allow osgi/stop command to specify more than one bundle per command entry.
> Encountered during SMX Kernel usage:
> smx@root:osgi> stop 180 177 176 173
> ERROR CommandLineExecutionFailed: org.apache.geronimo.gshell.command.CommandException: org.apache.geronimo.gshell.clp.ProcessingException: Too many arguments: 177
> In the above example a user would have to enter 'stop 180', 'stop 177', 'stop 176', and then finally 'stop173'. It would be nice to be able to specify a list of bundles to stop, in order, instead of having to issue a 'stop bundleId' command for each bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.