You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by kk...@apache.org on 2020/06/02 00:07:47 UTC
[kafka] branch 2.6 updated: MINOR: Code cleanup and assertion
message fixes in Connect integration tests (#8750)
This is an automated email from the ASF dual-hosted git repository.
kkarantasis pushed a commit to branch 2.6
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.6 by this push:
new 1cab31a MINOR: Code cleanup and assertion message fixes in Connect integration tests (#8750)
1cab31a is described below
commit 1cab31a40f6e81fb271eb50adaa12e6a4a2c6306
Author: showuon <43...@users.noreply.github.com>
AuthorDate: Tue Jun 2 08:04:34 2020 +0800
MINOR: Code cleanup and assertion message fixes in Connect integration tests (#8750)
1. Remove redundant connect#stop from test in InternalTopicsIntegrationTest since we'll do it after each test case in the @After method
2. Refine the error message in topic assertions to make it better explain the errors
Reviewers: Konstantine Karantasis <ko...@confluent.io>
---
.../kafka/connect/integration/InternalTopicsIntegrationTest.java | 2 --
.../kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java
index 1b92155..191de84 100644
--- a/connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java
+++ b/connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java
@@ -88,8 +88,6 @@ public class InternalTopicsIntegrationTest {
log.info("Verifying the internal topics for Connect");
connect.assertions().assertTopicsExist(configTopic(), offsetTopic(), statusTopic());
assertInternalTopicSettings();
-
- connect.stop();
}
@Test
diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java b/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
index 67143a1..587ea04 100644
--- a/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
+++ b/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
@@ -181,7 +181,7 @@ public class EmbeddedConnectClusterAssertions {
.collect(Collectors.toSet());
return Optional.of(comp.apply(actualExistingTopics, topicNames));
} catch (Exception e) {
- log.error("Could not check config validation error count.", e);
+ log.error("Failed to describe the topic(s): {}.", topicNames, e);
return Optional.empty();
}
}
@@ -223,7 +223,7 @@ public class EmbeddedConnectClusterAssertions {
&& topicDesc.partitions().stream().allMatch(p -> p.replicas().size() >= replicas);
return Optional.of(result);
} catch (Exception e) {
- log.error("Could not check config validation error count.", e);
+ log.error("Failed to describe the topic: {}.", topicName, e);
return Optional.empty();
}
}