You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2015/09/10 11:16:38 UTC

tapestry-5 git commit: TAP5-2308: add some client-side checks for invalid configuration

Repository: tapestry-5
Updated Branches:
  refs/heads/master 0fa5d92d9 -> 81e89ec4d


TAP5-2308: add some client-side checks for invalid configuration


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/81e89ec4
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/81e89ec4
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/81e89ec4

Branch: refs/heads/master
Commit: 81e89ec4d56ec92783d99e50e82227d1c411f2bc
Parents: 0fa5d92
Author: Jochen Kemnade <jo...@eddyson.de>
Authored: Thu Sep 10 11:16:08 2015 +0200
Committer: Jochen Kemnade <jo...@eddyson.de>
Committed: Thu Sep 10 11:16:08 2015 +0200

----------------------------------------------------------------------
 .../META-INF/modules/t5/core/form-fragment.coffee            | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/81e89ec4/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
index f4b92ea..bd89777 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/form-fragment.coffee
@@ -72,14 +72,20 @@ define ["underscore", "./dom", "./events", "./forms"],
     # * spec.fragmentId - id of FormFragment element
     # * spec.invert - (optional) if true, then checked trigger hides (not shows) the fragment
     linkTrigger = (spec) ->
+      unless spec.triggerId? then throw new Error "Incomplete parameters, triggerId is null"
+      unless spec.fragmentId? then throw new Error "Incomplete parameters, fragmentId is null"
       trigger = dom spec.triggerId
+      fragment = dom spec.fragmentId
+      if fragment is null
+        throw new Error "Invalid configuration, fragment with id #{spec.fragmentId} not found"
+
       invert = spec.invert or false
 
       update = ->
         checked = trigger.element.checked
         makeVisible = checked isnt invert
 
-        (dom spec.fragmentId).trigger events.formfragment.changeVisibility,  visible: makeVisible
+        fragment.trigger events.formfragment.changeVisibility,  visible: makeVisible
 
         return