You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/07/23 10:45:03 UTC
[GitHub] [brooklyn-server] jcabrerizo opened a new pull request #1210: Feature/entitlement execute script
jcabrerizo opened a new pull request #1210:
URL: https://github.com/apache/brooklyn-server/pull/1210
Adds a new `Entitlement` to control the Groovy script execution and a new `EntitlementManager` with "**PowerUser**" with the same entitlements as root but the ability to execute groovy scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1210: Feature/entitlement execute script
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1210:
URL: https://github.com/apache/brooklyn-server/pull/1210#discussion_r675479072
##########
File path: core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/Entitlements.java
##########
@@ -480,6 +503,8 @@ public static EntitlementManager load(@Nullable ManagementContext mgmt, Brooklyn
return minimal();
} else if ("user".equalsIgnoreCase(type)) {
return user();
+ } else if ("powerUser".equalsIgnoreCase(type) || "power_user".equalsIgnoreCase(type)) {
+ return powerUser();
Review comment:
Do we have constants for these to re-use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] jcabrerizo commented on a change in pull request #1210: Feature/entitlement execute script
Posted by GitBox <gi...@apache.org>.
jcabrerizo commented on a change in pull request #1210:
URL: https://github.com/apache/brooklyn-server/pull/1210#discussion_r675497190
##########
File path: core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/Entitlements.java
##########
@@ -480,6 +503,8 @@ public static EntitlementManager load(@Nullable ManagementContext mgmt, Brooklyn
return minimal();
} else if ("user".equalsIgnoreCase(type)) {
return user();
+ } else if ("powerUser".equalsIgnoreCase(type) || "power_user".equalsIgnoreCase(type)) {
+ return powerUser();
Review comment:
No for now. If we need to reuse the name of the entitlement manager we can create, but if not, I think is more clear to see directly the value here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] iuliana merged pull request #1210: Feature/entitlement execute script
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #1210:
URL: https://github.com/apache/brooklyn-server/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org