[GitHub] [helix] alirezazamani commented on a change in pull request #898: Add REST and JAVA API to modify existing cloudconfig

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #898: Add REST and JAVA API to modify existing cloudconfig
URL: https://github.com/apache/helix/pull/898#discussion_r392779034
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
 ##########
 @@ -604,7 +604,47 @@ public CloudConfig getCloudConfig(String clusterName) {
       return null;
     }
 
-    return new CloudConfig.Builder(record).build();
+    return new CloudConfig(record);
+  }
+
+  /**
+   * Delete cloud config fields (not the whole config)
+   * @param clusterName
+   * @param cloudConfig
+   */
+  public void deleteCloudConfigPatrial(String clusterName, CloudConfig cloudConfig) {
 
 Review comment:
   Changed to deleteCloudConfigFields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org