You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by uareurapid <gi...@git.apache.org> on 2016/01/05 13:43:02 UTC
[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...
GitHub user uareurapid opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/133
handle app store urls in system browser
I´ve found the following situation (on IOS app)...
I navigate to some website that has links to app store apps...
If the browser finds "https://itunes.apple.com" links they are turned into "itms-appss://" or "itms-apps://" and the browser fails to load them because it doesn´t know to handle them.
These should be opened in system browser and the webview should give up on them, cause it will fail to process them
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uareurapid/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/133.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #133
----
commit fa7c46a316fa4b773aa75742d9ceb10c40056e53
Author: PC Dreams (Paulo Cristo) <cr...@gmail.com>
Date: 2016-01-05T12:32:47Z
handle app store urls in system browser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/133#issuecomment-169105628
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...
Posted by magnusburton <gi...@git.apache.org>.
Github user magnusburton commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/133#issuecomment-178395468
Looks great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/133
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org