You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/27 04:08:47 UTC
[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #921: [SCB-2176] Fix:remove all instance properties and service properties …
robotLJW opened a new pull request #921:
URL: https://github.com/apache/servicecomb-service-center/pull/921
…& schemas
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #921: [SCB-2176] Fix:remove all instance properties and service properties …
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #921:
URL: https://github.com/apache/servicecomb-service-center/pull/921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang edited a comment on pull request #921: [SCB-2176] Fix:remove all instance properties and service properties …
Posted by GitBox <gi...@apache.org>.
tianxiaoliang edited a comment on pull request #921:
URL: https://github.com/apache/servicecomb-service-center/pull/921#issuecomment-808667213
与其做完copy再清除不如一开始就不copy，只copy需要的数据，根据tag进行排除，比如几层的结构体也没问题，用.进行连接，排除掉目标字段的copy，你可以把自己的场景发到copier社区，看看是否接纳。你排除的字段恰恰是大量的数据信息，开辟内存不是什么好事，容易被流量压垮
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #921: [SCB-2176] Fix:remove all instance properties and service properties …
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on pull request #921:
URL: https://github.com/apache/servicecomb-service-center/pull/921#issuecomment-808667213
与其做完copy再清除不如一开始就不copy，只copy需要的数据，根据tag进行排除，比如几层的结构体也没问题，用.进行连接，排除掉目标字段的copy，你可以把自己的场景发到copier社区，看看是否接纳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org