You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Matthias Wessendorf <ma...@apache.org> on 2007/03/07 19:37:00 UTC

A first Release Candidate ? (was Re: [Release] next steps...)

would be great to get some feedback on the artifacts, stored in this
staging repo:

http://people.apache.org/~matzew/stage_trin_core/

the *assembly* stuff I upload later/tomorrow

Thanks!
Matthias

On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> ok, after we got the plugins out...
> the logical next step is the core release of Trinidad!
>
> I was putting everything together we need for that.
> I added also two assembly maven2 projects
> (one for the libs and one for the demos)
>
> Also I added a BLANK demo, as discussed here on the dev list.
>
> everything is in this branch:
> http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
>
> I'd like to do mvn release:prepare tomorrow
>
> Thx,
> Matthias
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Matthias Wessendorf <ma...@apache.org>.
in place and started the vote ;)

On 3/9/07, Matthias Wessendorf <ma...@apache.org> wrote:
> Bernd-
>
> I added the CDDL notice to the -impl AND the dist.
> (not the example dist)
>
> Thx for pointing out. I'll deploy the *newer* version of this later today
>
> -M
>
> On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > On 3/8/07, Bernd Bohmann <be...@atanion.com> wrote:
> > > Hello Matthias,
> > >
> > > I think the notice file should contain a note for facelets and the
> > > license file the facelets license (please remove the prototype license
> > > from the license file :-)). The last stable release of facelets is
> > > 1.1.11 any reason to include 1.1.6 only?
> >
> > guess where that comes from ... :-)
> >
> > 1.1.6 was used... let's update on trunk to a more recent version
> >
> > > The dist and the example distributions contains double artifacts with a
> > > SNAPSHOT version may be a clean build needed.
> >
> > yeah... saw that, need to *deploy* the "fixed" stuff.
> >
> > -M
> >
> >
> > > Regards
> > >
> > > Bernd
> > >
> > >
> > >
> > > Matthias Wessendorf wrote:
> > > > I gave my apps a shot against the *candidate*, works fine..
> > > >
> > > > I'd like to start a vote on these bits, being our actual release.
> > > >
> > > > Any comments?
> > > >
> > > > -M
> > > >
> > > > On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > >> here is the trinidad dist:
> > > >>
> > > >> http://people.apache.org/~matzew/dist_trin_core/
> > > >>
> > > >> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > >> > would be great to get some feedback on the artifacts, stored in this
> > > >> > staging repo:
> > > >> >
> > > >> > http://people.apache.org/~matzew/stage_trin_core/
> > > >> >
> > > >> > the *assembly* stuff I upload later/tomorrow
> > > >> >
> > > >> > Thanks!
> > > >> > Matthias
> > > >> >
> > > >> > On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > >> > > ok, after we got the plugins out...
> > > >> > > the logical next step is the core release of Trinidad!
> > > >> > >
> > > >> > > I was putting everything together we need for that.
> > > >> > > I added also two assembly maven2 projects
> > > >> > > (one for the libs and one for the demos)
> > > >> > >
> > > >> > > Also I added a BLANK demo, as discussed here on the dev list.
> > > >> > >
> > > >> > > everything is in this branch:
> > > >> > >
> > > >> http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
> > > >>
> > > >> > >
> > > >> > > I'd like to do mvn release:prepare tomorrow
> > > >> > >
> > > >> > > Thx,
> > > >> > > Matthias
> > > >> > >
> > > >> > > --
> > > >> > > Matthias Wessendorf
> > > >> > > http://tinyurl.com/fmywh
> > > >> > >
> > > >> > > further stuff:
> > > >> > > blog: http://jroller.com/page/mwessendorf
> > > >> > > mail: mwessendorf-at-gmail-dot-com
> > > >> > >
> > > >> >
> > > >> >
> > > >> > --
> > > >> > Matthias Wessendorf
> > > >> > http://tinyurl.com/fmywh
> > > >> >
> > > >> > further stuff:
> > > >> > blog: http://jroller.com/page/mwessendorf
> > > >> > mail: mwessendorf-at-gmail-dot-com
> > > >> >
> > > >>
> > > >>
> > > >> --
> > > >> Matthias Wessendorf
> > > >> http://tinyurl.com/fmywh
> > > >>
> > > >> further stuff:
> > > >> blog: http://jroller.com/page/mwessendorf
> > > >> mail: mwessendorf-at-gmail-dot-com
> > > >>
> > > >
> > > >
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Matthias Wessendorf <ma...@apache.org>.
Bernd-

I added the CDDL notice to the -impl AND the dist.
(not the example dist)

Thx for pointing out. I'll deploy the *newer* version of this later today

-M

On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> On 3/8/07, Bernd Bohmann <be...@atanion.com> wrote:
> > Hello Matthias,
> >
> > I think the notice file should contain a note for facelets and the
> > license file the facelets license (please remove the prototype license
> > from the license file :-)). The last stable release of facelets is
> > 1.1.11 any reason to include 1.1.6 only?
>
> guess where that comes from ... :-)
>
> 1.1.6 was used... let's update on trunk to a more recent version
>
> > The dist and the example distributions contains double artifacts with a
> > SNAPSHOT version may be a clean build needed.
>
> yeah... saw that, need to *deploy* the "fixed" stuff.
>
> -M
>
>
> > Regards
> >
> > Bernd
> >
> >
> >
> > Matthias Wessendorf wrote:
> > > I gave my apps a shot against the *candidate*, works fine..
> > >
> > > I'd like to start a vote on these bits, being our actual release.
> > >
> > > Any comments?
> > >
> > > -M
> > >
> > > On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > >> here is the trinidad dist:
> > >>
> > >> http://people.apache.org/~matzew/dist_trin_core/
> > >>
> > >> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > >> > would be great to get some feedback on the artifacts, stored in this
> > >> > staging repo:
> > >> >
> > >> > http://people.apache.org/~matzew/stage_trin_core/
> > >> >
> > >> > the *assembly* stuff I upload later/tomorrow
> > >> >
> > >> > Thanks!
> > >> > Matthias
> > >> >
> > >> > On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > >> > > ok, after we got the plugins out...
> > >> > > the logical next step is the core release of Trinidad!
> > >> > >
> > >> > > I was putting everything together we need for that.
> > >> > > I added also two assembly maven2 projects
> > >> > > (one for the libs and one for the demos)
> > >> > >
> > >> > > Also I added a BLANK demo, as discussed here on the dev list.
> > >> > >
> > >> > > everything is in this branch:
> > >> > >
> > >> http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
> > >>
> > >> > >
> > >> > > I'd like to do mvn release:prepare tomorrow
> > >> > >
> > >> > > Thx,
> > >> > > Matthias
> > >> > >
> > >> > > --
> > >> > > Matthias Wessendorf
> > >> > > http://tinyurl.com/fmywh
> > >> > >
> > >> > > further stuff:
> > >> > > blog: http://jroller.com/page/mwessendorf
> > >> > > mail: mwessendorf-at-gmail-dot-com
> > >> > >
> > >> >
> > >> >
> > >> > --
> > >> > Matthias Wessendorf
> > >> > http://tinyurl.com/fmywh
> > >> >
> > >> > further stuff:
> > >> > blog: http://jroller.com/page/mwessendorf
> > >> > mail: mwessendorf-at-gmail-dot-com
> > >> >
> > >>
> > >>
> > >> --
> > >> Matthias Wessendorf
> > >> http://tinyurl.com/fmywh
> > >>
> > >> further stuff:
> > >> blog: http://jroller.com/page/mwessendorf
> > >> mail: mwessendorf-at-gmail-dot-com
> > >>
> > >
> > >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Matthias Wessendorf <ma...@apache.org>.
On 3/8/07, Bernd Bohmann <be...@atanion.com> wrote:
> Hello Matthias,
>
> I think the notice file should contain a note for facelets and the
> license file the facelets license (please remove the prototype license
> from the license file :-)). The last stable release of facelets is
> 1.1.11 any reason to include 1.1.6 only?

guess where that comes from ... :-)

1.1.6 was used... let's update on trunk to a more recent version

> The dist and the example distributions contains double artifacts with a
> SNAPSHOT version may be a clean build needed.

yeah... saw that, need to *deploy* the "fixed" stuff.

-M


> Regards
>
> Bernd
>
>
>
> Matthias Wessendorf wrote:
> > I gave my apps a shot against the *candidate*, works fine..
> >
> > I'd like to start a vote on these bits, being our actual release.
> >
> > Any comments?
> >
> > -M
> >
> > On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >> here is the trinidad dist:
> >>
> >> http://people.apache.org/~matzew/dist_trin_core/
> >>
> >> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >> > would be great to get some feedback on the artifacts, stored in this
> >> > staging repo:
> >> >
> >> > http://people.apache.org/~matzew/stage_trin_core/
> >> >
> >> > the *assembly* stuff I upload later/tomorrow
> >> >
> >> > Thanks!
> >> > Matthias
> >> >
> >> > On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> >> > > ok, after we got the plugins out...
> >> > > the logical next step is the core release of Trinidad!
> >> > >
> >> > > I was putting everything together we need for that.
> >> > > I added also two assembly maven2 projects
> >> > > (one for the libs and one for the demos)
> >> > >
> >> > > Also I added a BLANK demo, as discussed here on the dev list.
> >> > >
> >> > > everything is in this branch:
> >> > >
> >> http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
> >>
> >> > >
> >> > > I'd like to do mvn release:prepare tomorrow
> >> > >
> >> > > Thx,
> >> > > Matthias
> >> > >
> >> > > --
> >> > > Matthias Wessendorf
> >> > > http://tinyurl.com/fmywh
> >> > >
> >> > > further stuff:
> >> > > blog: http://jroller.com/page/mwessendorf
> >> > > mail: mwessendorf-at-gmail-dot-com
> >> > >
> >> >
> >> >
> >> > --
> >> > Matthias Wessendorf
> >> > http://tinyurl.com/fmywh
> >> >
> >> > further stuff:
> >> > blog: http://jroller.com/page/mwessendorf
> >> > mail: mwessendorf-at-gmail-dot-com
> >> >
> >>
> >>
> >> --
> >> Matthias Wessendorf
> >> http://tinyurl.com/fmywh
> >>
> >> further stuff:
> >> blog: http://jroller.com/page/mwessendorf
> >> mail: mwessendorf-at-gmail-dot-com
> >>
> >
> >
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Bernd Bohmann <be...@atanion.com>.
Hello Matthias,

I think the notice file should contain a note for facelets and the 
license file the facelets license (please remove the prototype license 
from the license file :-)). The last stable release of facelets is 
1.1.11 any reason to include 1.1.6 only?

The dist and the example distributions contains double artifacts with a 
SNAPSHOT version may be a clean build needed.

Regards

Bernd



Matthias Wessendorf wrote:
> I gave my apps a shot against the *candidate*, works fine..
> 
> I'd like to start a vote on these bits, being our actual release.
> 
> Any comments?
> 
> -M
> 
> On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
>> here is the trinidad dist:
>>
>> http://people.apache.org/~matzew/dist_trin_core/
>>
>> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
>> > would be great to get some feedback on the artifacts, stored in this
>> > staging repo:
>> >
>> > http://people.apache.org/~matzew/stage_trin_core/
>> >
>> > the *assembly* stuff I upload later/tomorrow
>> >
>> > Thanks!
>> > Matthias
>> >
>> > On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
>> > > ok, after we got the plugins out...
>> > > the logical next step is the core release of Trinidad!
>> > >
>> > > I was putting everything together we need for that.
>> > > I added also two assembly maven2 projects
>> > > (one for the libs and one for the demos)
>> > >
>> > > Also I added a BLANK demo, as discussed here on the dev list.
>> > >
>> > > everything is in this branch:
>> > > 
>> http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/ 
>>
>> > >
>> > > I'd like to do mvn release:prepare tomorrow
>> > >
>> > > Thx,
>> > > Matthias
>> > >
>> > > --
>> > > Matthias Wessendorf
>> > > http://tinyurl.com/fmywh
>> > >
>> > > further stuff:
>> > > blog: http://jroller.com/page/mwessendorf
>> > > mail: mwessendorf-at-gmail-dot-com
>> > >
>> >
>> >
>> > --
>> > Matthias Wessendorf
>> > http://tinyurl.com/fmywh
>> >
>> > further stuff:
>> > blog: http://jroller.com/page/mwessendorf
>> > mail: mwessendorf-at-gmail-dot-com
>> >
>>
>>
>> -- 
>> Matthias Wessendorf
>> http://tinyurl.com/fmywh
>>
>> further stuff:
>> blog: http://jroller.com/page/mwessendorf
>> mail: mwessendorf-at-gmail-dot-com
>>
> 
> 

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Matthias Wessendorf <ma...@apache.org>.
I gave my apps a shot against the *candidate*, works fine..

I'd like to start a vote on these bits, being our actual release.

Any comments?

-M

On 3/8/07, Matthias Wessendorf <ma...@apache.org> wrote:
> here is the trinidad dist:
>
> http://people.apache.org/~matzew/dist_trin_core/
>
> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > would be great to get some feedback on the artifacts, stored in this
> > staging repo:
> >
> > http://people.apache.org/~matzew/stage_trin_core/
> >
> > the *assembly* stuff I upload later/tomorrow
> >
> > Thanks!
> > Matthias
> >
> > On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > > ok, after we got the plugins out...
> > > the logical next step is the core release of Trinidad!
> > >
> > > I was putting everything together we need for that.
> > > I added also two assembly maven2 projects
> > > (one for the libs and one for the demos)
> > >
> > > Also I added a BLANK demo, as discussed here on the dev list.
> > >
> > > everything is in this branch:
> > > http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
> > >
> > > I'd like to do mvn release:prepare tomorrow
> > >
> > > Thx,
> > > Matthias
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: A first Release Candidate ? (was Re: [Release] next steps...)

Posted by Matthias Wessendorf <ma...@apache.org>.
here is the trinidad dist:

http://people.apache.org/~matzew/dist_trin_core/

On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> would be great to get some feedback on the artifacts, stored in this
> staging repo:
>
> http://people.apache.org/~matzew/stage_trin_core/
>
> the *assembly* stuff I upload later/tomorrow
>
> Thanks!
> Matthias
>
> On 3/7/07, Matthias Wessendorf <ma...@apache.org> wrote:
> > ok, after we got the plugins out...
> > the logical next step is the core release of Trinidad!
> >
> > I was putting everything together we need for that.
> > I added also two assembly maven2 projects
> > (one for the libs and one for the demos)
> >
> > Also I added a BLANK demo, as discussed here on the dev list.
> >
> > everything is in this branch:
> > http://svn.apache.org/viewvc/incubator/adffaces/branches/matzew-core-1.0.0-incubation/
> >
> > I'd like to do mvn release:prepare tomorrow
> >
> > Thx,
> > Matthias
> >
> > --
> > Matthias Wessendorf
> > http://tinyurl.com/fmywh
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: tr:datetimeconverter and shortish style

Posted by Matthias Wessendorf <ma...@apache.org>.
fine w/ me

-M

On 3/22/07, Gabrielle Crawford <ga...@oracle.com> wrote:
> This seems like a fine fix, I will merge this unless there are objections.
>
> Thanks,
>
> Gab
>
> On 3/15/2007 3:12 PM, Yee-wah Lee wrote:
>
> >
> > I've filed JIRA ADF-Faces 410 on this:
> > https://issues.apache.org/jira/browse/ADFFACES-410
> >
> > In there I suggest a fix to use the 4-digit pattern when formatting,
> > but the 2-digit pattern when parsing. That involves adding a param to
> > the protected method getDateFormat(..boolean forParsing), and using
> > that param to determine when to run "_get4YearFormat()" which fixes up
> > the DateFormat object.
> > Please let me know/comment on the JIRA if you see any issues.
> >
> > Thanks,
> > Yee-Wah
> >
> > On 3/9/2007 11:30 AM PST, Adam Winer wrote:
> >
> >> The intent of the code is absolutely to use the two-digit
> >> year start to handle two-digits entries.  If that isn't happening,
> >> it's a pretty bad bug.
> >>
> >> -- Adam
> >>
> >>
> >> On 3/8/07, Yee-wah Lee <ye...@oracle.com> wrote:
> >>
> >>> Hi all,
> >>>
> >>> I see the following code in the (server-side) DateTimeConverter and
> >>> think it may be problematic.
> >>>
> >>> 1) The default style for dates is set to shortish, which forces the
> >>> year
> >>> pattern to be at least 4 digits
> >>> (http://incubator.apache.org/adffaces/trinidad-api/apidocs/org/apache/myfaces/trinidad/convert/DateTimeConverter.html)
> >>>
> >>> /New dateStyle |shortish| has been introduced. Shortish is identical to
> >>> |short| but forces the year to be a full four digits. If dateStyle is
> >>> not set, then |dateStyle| defaults to |shortish|.
> >>> /
> >>> 2) Accordingly, the converter sets the pattern on its DateFormat to use
> >>> at least 4 digits, if 'y' appears at all. The method is
> >>> _get4YearFormat()
> >>>
> >>> 3) Now, the Javadoc states this for SimpleDateFormat
> >>> (http://java.sun.com/j2se/1.5.0/docs/api/java/text/SimpleDateFormat.html)
> >>>
> >>> /For parsing, if the number of pattern letters is more than 2, the year
> >>> is interpreted literally, regardless of the number of digits. So using
> >>> the pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
> >>> /
> >>> So why I think this is a problem:
> >>>
> >>>     *  From the user's perspective, if they enters a date like
> >>>       '1/31/07', it becomes January 31st, 7 A.D rather than the (more
> >>>       likely intended) January 31st, 2007.
> >>>     *  It also seems like the code intends otherwise, because it also
> >>>       calls DateFormat's set2DigitYearStart() which is intended for
> >>>       parsing 2 digit years.
> >>>
> >>> Does anyone have more background on this? I was able to reproduce the
> >>> behavior using an inputText bound to a backing Date value, and a
> >>> DateTimeConverter attached to it.
> >>>
> >>> Thanks,
> >>> Yee-Wah
> >>>
> >>>
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: tr:datetimeconverter and shortish style

Posted by Gabrielle Crawford <ga...@oracle.com>.
This seems like a fine fix, I will merge this unless there are objections.

Thanks,

Gab

On 3/15/2007 3:12 PM, Yee-wah Lee wrote:

>
> I've filed JIRA ADF-Faces 410 on this:
> https://issues.apache.org/jira/browse/ADFFACES-410
>
> In there I suggest a fix to use the 4-digit pattern when formatting, 
> but the 2-digit pattern when parsing. That involves adding a param to 
> the protected method getDateFormat(..boolean forParsing), and using 
> that param to determine when to run "_get4YearFormat()" which fixes up 
> the DateFormat object.
> Please let me know/comment on the JIRA if you see any issues.
>
> Thanks,
> Yee-Wah
>
> On 3/9/2007 11:30 AM PST, Adam Winer wrote:
>
>> The intent of the code is absolutely to use the two-digit
>> year start to handle two-digits entries.  If that isn't happening,
>> it's a pretty bad bug.
>>
>> -- Adam
>>
>>
>> On 3/8/07, Yee-wah Lee <ye...@oracle.com> wrote:
>>
>>> Hi all,
>>>
>>> I see the following code in the (server-side) DateTimeConverter and
>>> think it may be problematic.
>>>
>>> 1) The default style for dates is set to shortish, which forces the 
>>> year
>>> pattern to be at least 4 digits
>>> (http://incubator.apache.org/adffaces/trinidad-api/apidocs/org/apache/myfaces/trinidad/convert/DateTimeConverter.html) 
>>>
>>> /New dateStyle |shortish| has been introduced. Shortish is identical to
>>> |short| but forces the year to be a full four digits. If dateStyle is
>>> not set, then |dateStyle| defaults to |shortish|.
>>> /
>>> 2) Accordingly, the converter sets the pattern on its DateFormat to use
>>> at least 4 digits, if 'y' appears at all. The method is 
>>> _get4YearFormat()
>>>
>>> 3) Now, the Javadoc states this for SimpleDateFormat
>>> (http://java.sun.com/j2se/1.5.0/docs/api/java/text/SimpleDateFormat.html) 
>>>
>>> /For parsing, if the number of pattern letters is more than 2, the year
>>> is interpreted literally, regardless of the number of digits. So using
>>> the pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
>>> /
>>> So why I think this is a problem:
>>>
>>>     *  From the user's perspective, if they enters a date like
>>>       '1/31/07', it becomes January 31st, 7 A.D rather than the (more
>>>       likely intended) January 31st, 2007.
>>>     *  It also seems like the code intends otherwise, because it also
>>>       calls DateFormat's set2DigitYearStart() which is intended for
>>>       parsing 2 digit years.
>>>
>>> Does anyone have more background on this? I was able to reproduce the
>>> behavior using an inputText bound to a backing Date value, and a
>>> DateTimeConverter attached to it.
>>>
>>> Thanks,
>>> Yee-Wah
>>>
>>>

Re: tr:datetimeconverter and shortish style

Posted by Yee-wah Lee <ye...@oracle.com>.
I've filed JIRA ADF-Faces 410 on this:
https://issues.apache.org/jira/browse/ADFFACES-410

In there I suggest a fix to use the 4-digit pattern when formatting, but 
the 2-digit pattern when parsing. That involves adding a param to the 
protected method getDateFormat(..boolean forParsing), and using that 
param to determine when to run "_get4YearFormat()" which fixes up the 
DateFormat object. 

Please let me know/comment on the JIRA if you see any issues.

Thanks,
Yee-Wah

On 3/9/2007 11:30 AM PST, Adam Winer wrote:
> The intent of the code is absolutely to use the two-digit
> year start to handle two-digits entries.  If that isn't happening,
> it's a pretty bad bug.
>
> -- Adam
>
>
> On 3/8/07, Yee-wah Lee <ye...@oracle.com> wrote:
>> Hi all,
>>
>> I see the following code in the (server-side) DateTimeConverter and
>> think it may be problematic.
>>
>> 1) The default style for dates is set to shortish, which forces the year
>> pattern to be at least 4 digits
>> (http://incubator.apache.org/adffaces/trinidad-api/apidocs/org/apache/myfaces/trinidad/convert/DateTimeConverter.html) 
>>
>> /New dateStyle |shortish| has been introduced. Shortish is identical to
>> |short| but forces the year to be a full four digits. If dateStyle is
>> not set, then |dateStyle| defaults to |shortish|.
>> /
>> 2) Accordingly, the converter sets the pattern on its DateFormat to use
>> at least 4 digits, if 'y' appears at all. The method is 
>> _get4YearFormat()
>>
>> 3) Now, the Javadoc states this for SimpleDateFormat
>> (http://java.sun.com/j2se/1.5.0/docs/api/java/text/SimpleDateFormat.html) 
>>
>> /For parsing, if the number of pattern letters is more than 2, the year
>> is interpreted literally, regardless of the number of digits. So using
>> the pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
>> /
>> So why I think this is a problem:
>>
>>     *  From the user's perspective, if they enters a date like
>>       '1/31/07', it becomes January 31st, 7 A.D rather than the (more
>>       likely intended) January 31st, 2007.
>>     *  It also seems like the code intends otherwise, because it also
>>       calls DateFormat's set2DigitYearStart() which is intended for
>>       parsing 2 digit years.
>>
>> Does anyone have more background on this? I was able to reproduce the
>> behavior using an inputText bound to a backing Date value, and a
>> DateTimeConverter attached to it.
>>
>> Thanks,
>> Yee-Wah
>>
>>

Re: tr:datetimeconverter and shortish style

Posted by Adam Winer <aw...@gmail.com>.
The intent of the code is absolutely to use the two-digit
year start to handle two-digits entries.  If that isn't happening,
it's a pretty bad bug.

-- Adam


On 3/8/07, Yee-wah Lee <ye...@oracle.com> wrote:
> Hi all,
>
> I see the following code in the (server-side) DateTimeConverter and
> think it may be problematic.
>
> 1) The default style for dates is set to shortish, which forces the year
> pattern to be at least 4 digits
> (http://incubator.apache.org/adffaces/trinidad-api/apidocs/org/apache/myfaces/trinidad/convert/DateTimeConverter.html)
> /New dateStyle |shortish| has been introduced. Shortish is identical to
> |short| but forces the year to be a full four digits. If dateStyle is
> not set, then |dateStyle| defaults to |shortish|.
> /
> 2) Accordingly, the converter sets the pattern on its DateFormat to use
> at least 4 digits, if 'y' appears at all. The method is _get4YearFormat()
>
> 3) Now, the Javadoc states this for SimpleDateFormat
> (http://java.sun.com/j2se/1.5.0/docs/api/java/text/SimpleDateFormat.html)
> /For parsing, if the number of pattern letters is more than 2, the year
> is interpreted literally, regardless of the number of digits. So using
> the pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
> /
> So why I think this is a problem:
>
>     *  From the user's perspective, if they enters a date like
>       '1/31/07', it becomes January 31st, 7 A.D rather than the (more
>       likely intended) January 31st, 2007.
>     *  It also seems like the code intends otherwise, because it also
>       calls DateFormat's set2DigitYearStart() which is intended for
>       parsing 2 digit years.
>
> Does anyone have more background on this? I was able to reproduce the
> behavior using an inputText bound to a backing Date value, and a
> DateTimeConverter attached to it.
>
> Thanks,
> Yee-Wah
>
>

tr:datetimeconverter and shortish style

Posted by Yee-wah Lee <ye...@oracle.com>.
Hi all,

I see the following code in the (server-side) DateTimeConverter and 
think it may be problematic.

1) The default style for dates is set to shortish, which forces the year 
pattern to be at least 4 digits 
(http://incubator.apache.org/adffaces/trinidad-api/apidocs/org/apache/myfaces/trinidad/convert/DateTimeConverter.html)
/New dateStyle |shortish| has been introduced. Shortish is identical to 
|short| but forces the year to be a full four digits. If dateStyle is 
not set, then |dateStyle| defaults to |shortish|.
/
2) Accordingly, the converter sets the pattern on its DateFormat to use 
at least 4 digits, if 'y' appears at all. The method is _get4YearFormat()

3) Now, the Javadoc states this for SimpleDateFormat 
(http://java.sun.com/j2se/1.5.0/docs/api/java/text/SimpleDateFormat.html)
/For parsing, if the number of pattern letters is more than 2, the year 
is interpreted literally, regardless of the number of digits. So using 
the pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
/
So why I think this is a problem:

    *  From the user's perspective, if they enters a date like
      '1/31/07', it becomes January 31st, 7 A.D rather than the (more
      likely intended) January 31st, 2007.
    *  It also seems like the code intends otherwise, because it also
      calls DateFormat's set2DigitYearStart() which is intended for
      parsing 2 digit years.

Does anyone have more background on this? I was able to reproduce the 
behavior using an inputText bound to a backing Date value, and a 
DateTimeConverter attached to it.

Thanks,
Yee-Wah