You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/28 15:00:25 UTC

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6632: Remove the close_before_method and close_after_method parameters of custom-enhance-plugin to avoid memory leaks

codecov[bot] edited a comment on pull request #6632:
URL: https://github.com/apache/skywalking/pull/6632#issuecomment-808867229


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=h1) Report
   > Merging [#6632](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=desc) (20413bd) into [master](https://codecov.io/gh/apache/skywalking/commit/db9cc26977690faeb0bc3c9cb1c8f5b326d38621?el=desc) (db9cc26) will **increase** coverage by `25.50%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 20413bd differs from pull request most recent head aff9482. Consider uploading reports for the commit aff9482 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6632/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6632       +/-   ##
   =============================================
   + Coverage     28.04%   53.55%   +25.50%     
   - Complexity        0     4149     +4149     
   =============================================
     Files          1709     1797       +88     
     Lines         36117    38580     +2463     
     Branches       4508     4214      -294     
   =============================================
   + Hits          10129    20661    +10532     
   + Misses        25035    16929     -8106     
   - Partials        953      990       +37     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../plugin/customize/conf/CustomizeConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvY29uZi9DdXN0b21pemVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...apm/plugin/customize/conf/MethodConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvY29uZi9NZXRob2RDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../customize/interceptor/BaseInterceptorMethods.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9jdXN0b21pemUtZW5oYW5jZS1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9jdXN0b21pemUvaW50ZXJjZXB0b3IvQmFzZUludGVyY2VwdG9yTWV0aG9kcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (-81.56%)` | `0.00% <0.00%> (ø%)` | |
   | [...oap/server/receiver/envoy/als/ServiceMetaInfo.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1NlcnZpY2VNZXRhSW5mby5qYXZh) | `20.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `25.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ver/core/alarm/provider/grpc/GRPCAlarmSetting.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9ncnBjL0dSUENBbGFybVNldHRpbmcuamF2YQ==) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...rver/cluster/plugin/zookeeper/NodeNameBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci16b29rZWVwZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vem9va2VlcGVyL05vZGVOYW1lQnVpbGRlci5qYXZh) | `50.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `36.36% <0.00%> (-43.64%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [850 more](https://codecov.io/gh/apache/skywalking/pull/6632/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=footer). Last update [db9cc26...aff9482](https://codecov.io/gh/apache/skywalking/pull/6632?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org