[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1525: HDDS-3959. Avoid HddsProtos.PipelineID#toString

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #1525:
URL: https://github.com/apache/hadoop-ozone/pull/1525


   ## What changes were proposed in this pull request?
   
   Change `CreatePipelineCommandHandler` and `ClosePipelineCommandHandler` to use the non-proto `PipelineID` object for logging.  This lets us avoid printing multi-line messages, mostly caused by `uuid128` structure.
   
   Also tweak logic a bit to avoid unnecessary back and forth proto conversion for getting the node list in pipeline creation.
   
   https://issues.apache.org/jira/browse/HDDS-3959
   
   ## How was this patch tested?
   
   Ran `ozone` docker compose cluster, closed one pipeline manually, verified log messages:
   
   ```
   datanode_1  | 2020-10-27 09:58:13,533 [Command processor thread] INFO commandhandler.CreatePipelineCommandHandler: Created Pipeline RATIS THREE PipelineID=658bfc91-c07c-405f-94ab-7b7a87c9dd2c.
   ...
   datanode_2  | 2020-10-27 10:02:00,686 [Command processor thread] INFO commandhandler.ClosePipelineCommandHandler: Close Pipeline PipelineID=658bfc91-c07c-405f-94ab-7b7a87c9dd2c command on datanode fea867c0-2e70-45ec-8491-be7f952d91a4.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org