[GitHub] [guacamole-client] necouchman commented on a change in pull request #497: GUACAMOLE-996: Add support for configuring group filter.

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #497:
URL: https://github.com/apache/guacamole-client/pull/497#discussion_r429588360



##########
File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java
##########
@@ -87,9 +87,9 @@ private ExprNode getGroupSearchFilter() throws GuacamoleException {
         if (confService.getConfigurationBaseDN() != null)
             return new NotNode(new EqualityNode("objectClass","guacConfigGroup"));

Review comment:
       Retrieve everything under `groupBaseDN` NOT containing `guacConfigGroup`.  Basically, the previous code made the assumption that, if you've configured a DN for configuration items you've also extended your LDAP schema to include the `guacConfigGroup` schema item, and that you do not want those being returned by the groups filter, you want them being returned in the config search.  That is still the case in the line mentioned above, but the new group filter needs to be and-ed with that logic.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org