You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2008/08/10 21:44:12 UTC
svn commit: r684579 -
/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java
Author: olegk
Date: Sun Aug 10 12:44:11 2008
New Revision: 684579
URL: http://svn.apache.org/viewvc?rev=684579&view=rev
Log:
HTTPCORE-168: BasicNameValuePair made Serializable
Contributed by Sanne Grinovero <sanne.grinovero at gmail dot>
Modified:
httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java
Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java?rev=684579&r1=684578&r2=684579&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java (original)
+++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java Sun Aug 10 12:44:11 2008
@@ -31,6 +31,8 @@
package org.apache.http.message;
+import java.io.Serializable;
+
import org.apache.http.NameValuePair;
import org.apache.http.util.CharArrayBuffer;
import org.apache.http.util.LangUtils;
@@ -103,7 +105,9 @@
* @author <a href="mailto:oleg at ural.com">Oleg Kalnichevski</a>
*
*/
-public class BasicNameValuePair implements NameValuePair, Cloneable {
+public class BasicNameValuePair implements NameValuePair, Cloneable, Serializable {
+
+ private static final long serialVersionUID = -6437800749411518984L;
private final String name;
private final String value;
@@ -149,18 +153,17 @@
*/
public String toString() {
// don't call complex default formatting for a simple toString
-
- int len = this.name.length();
- if (this.value != null)
- len += 1 + this.value.length();
- CharArrayBuffer buffer = new CharArrayBuffer(len);
-
- buffer.append(this.name);
- if (this.value != null) {
+
+ if (this.value == null) {
+ return name;
+ } else {
+ int len = this.name.length() + 1 + this.value.length();
+ CharArrayBuffer buffer = new CharArrayBuffer(len);
+ buffer.append(this.name);
buffer.append("=");
buffer.append(this.value);
+ return buffer.toString();
}
- return buffer.toString();
}
public boolean equals(final Object object) {