You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/09 19:46:36 UTC

[GitHub] [cloudstack] stephankruggg opened a new pull request, #6892: Externalize KVM HA heartbeat frequency

stephankruggg opened a new pull request, #6892:
URL: https://github.com/apache/cloudstack/pull/6892

   ### Description
   
   Currently, the heartbeat frequency of the KVM HA is fixed at 60,000 milliseconds. This property was externalized as `kvm.heartbeat.update.frequency` in `agent.properties`.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   
   ### How Has This Been Tested?
   I applied the changes in a local lab, changed the frequency, and checked if heartbeats were occurring at the frequency I specified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1329425542

   Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386718586

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5304


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1414430188

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6892)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL)
   
   [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1759559118

   > Test | Result | Time (s) | Test File
   > --- | --- | --- | ---
   > test_11_destroy_ssvm | `Failure` | 912.96 | test_ssvm.py
   > test_03_deploy_vm_wrong_checksum | `Error` | 41.87 | test_templates.py
   > test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
   
   templates are aknown issue, retrying to see if the ssvm issue is persistent
   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1752710448

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1788639392

   @blueorangutan test alma9 kvm-alma9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1752589198

   @shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1758835656

   <b>[SF] Trillian test result (tid-7923)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44598 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t7923-kvm-centos7.zip
   Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_destroy_ssvm | `Failure` | 912.96 | test_ssvm.py
   test_03_deploy_vm_wrong_checksum | `Error` | 41.87 | test_templates.py
   test_09_list_templates_download_details | `Failure` | 0.04 | test_templates.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GaOrtiga commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "GaOrtiga (via GitHub)" <gi...@apache.org>.
GaOrtiga commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1731196476

   As mentioned in comment https://github.com/apache/cloudstack/pull/6947#issuecomment-1611851403, I will be helping out @stephankruggg  with some of his opened PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386079381

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6892)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL)
   
   [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384207549

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1312700110

   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335385885

   @stephankruggg in my test env I keep seeing this:
   ```
   "2022-12-02 14:36:53 Adding KVM host pr6892-t5375-kvm-centos7-kvm1.", "🙈 Error: (HTTP 530, error code 9999) Could not add host at [http://10.0.33.209/] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!]
   ```
   can you explain that?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073451284


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   @weizhouapache, speaking as a member of the SC Clouds team, every PR opened by someone from SC Clouds already attends to the use case the company faced. In this case, externalizing the property `kvm.heartbeat.update.frequency` already attends the SC Clouds use case. Therefore, if there are improvements to be done or other cases to be considered within the proposal's boundaries, the community should point them out; otherwise, if the community thinks it is ok as it is, then there is nothing else to address.
   
   Now, speaking as a member of the community, once a PR is opened, it does not matter from which company the contributor who opened the PR is; it is a contribution from someone to the community and should be treated as so. The bond is not the company with the community, is the contributor with the community; the contributor's team is the community. Then, when @stephankruggg asked you `what other variables would you consider necessary to externalize` he was already discussing with the team (the community) if other variables should be externalized. Also, we have to remember that not all contributions are based on a company's motivation; contributors want the best for the project and may contribute to the community's evolution independently of a company saying them to do so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1080947374


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   before this becomes a an even more big discussion: let's stick to the question of whetther we keep it to this setting and go through the trouble of testing new PRs when we want other setting, or we add as much settings as we can now?
   I see the rest of the discussion as useful, no doubt but it kind of transcends this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384268566

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "GaOrtiga (via GitHub)" <gi...@apache.org>.
GaOrtiga commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1810831578

   > ai, conflicts, Can you have a look @GaOrtiga (cc @stephankruggg )
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1761173845

   has anybody besides @stephankruggg tested this? cc @shwstppr @weizhouapache @rohityadavcloud @GutoVeronezi 
   
   I think it is good to merge. the errors in the smoke tests are not related, but we are again growing our number of consistent failures :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1752750557

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1787293172

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "GaOrtiga (via GitHub)" <gi...@apache.org>.
GaOrtiga commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1792745027

   > @GaOrtiga @stephankruggg , is this ready for merge?
   
   @DaanHoogland, Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "GaOrtiga (via GitHub)" <gi...@apache.org>.
GaOrtiga commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1755633917

   As mentioned in comment https://github.com/apache/cloudstack/pull/6947#issuecomment-1611851403, I will be helping out @stephankruggg with some of his opened PRs.
   @weizhouapache @DaanHoogland As we are using objects here, I agree `L` would be the best option. The impact of the auto boxing in runtime caused by using `l` is quite unnoticeable; but it costs nothing to do this adjust.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1760647748

   <b>[SF] Trillian test result (tid-7942)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44974 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t7942-kvm-centos7.zip
   Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Failure` | 580.19 | test_kubernetes_clusters.py
   test_create_pvlan_network | `Error` | 0.06 | test_pvlan.py
   test_03_deploy_vm_wrong_checksum | `Error` | 39.64 | test_templates.py
   test_09_list_templates_download_details | `Failure` | 0.05 | test_templates.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1495873401

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335375583

   <b>Trillian Build Failed (tid-5375)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386650187

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357378272

   <b>Trillian Build Failed (tid-5553)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334066712

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384206242

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384292409

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1083751718


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   thanks @stephankruggg , I'll await your ping to work on merging this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by github-actions.
github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1403567998

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1790273228

   @GaOrtiga @stephankruggg , is this ready for merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1752749757

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1812729729

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1811988349

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1309362458

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6892)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL)
   
   [![50.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50-16px.png '50.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list) [50.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310237147

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072572879


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   > (1) The focus of this PR is only the `heartBeatUpdateFreq`. What other variables would you consider necessary to externalize? (2) Yes, this will be fixed.
   
   @stephankruggg 
   good. 
   can you discuss with your team if other fixed values need be configurable as well ?
   if you want only this configurable, it is ok.
   if you want more to be configurable, you can make all the changes in this PR.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1625980482

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1788641206

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1755452007

   > just one remark, would be better to use `L` instead of `l` for long value ? @stephankruggg @shwstppr @DaanHoogland
   
   The only reason is that l and 1 look so much alike, in some fonts. It'll work lie this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1757655042

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1811985003

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1812679961

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7762


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384828744

   <b>Trillian test result (tid-5873)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43162 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t5873-kvm-centos7.zip
   Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 568.43 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1354760878

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1350735937

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384293739

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1309962646

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310238474

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1309961554

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1757657782

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1757783471

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1567949352

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334949700

   <b>Trillian Build Failed (tid-5342)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1332166566

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357556145

   > management:
   > 
   > ```
   > 022-12-02 14:36:53,653 DEBUG [c.c.a.ApiServlet] (qtp262366552-16:ctx-738fd6f7) (logid:944d439c) ===START===  10.0.35.111 -- GET  apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&clusterid=a94
   > 89c75-dbcc-4a51-8081-a76fdff1345b&command=addHost&hypervisor=KVM&podid=1ca6f4d3-fe8b-4eaf-be94-915fcd313a08&response=json&url=http%3A%2F%2F10.0.33.209&username=root&zoneid=ddb1c828-a5eb-4010-83c6-cd9a681a9972&signature=VVRH4DxK1Kow9bs%2B
   > jnuzGlWRam0%3D
   > 2022-12-02 14:36:53,657 DEBUG [c.c.a.ApiServer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]' is allowed to 
   > perform API calls: 0.0.0.0/0,::/0
   > 2022-12-02 14:36:53,659 INFO  [o.a.c.a.DynamicRoleBasedAPIAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Account [Account [{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]] is Roo
   > t Admin or Domain Admin, all APIs are allowed.
   > 2022-12-02 14:36:53,660 WARN  [o.a.c.a.ProjectRoleBasedApiAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Project is null, ProjectRoleBasedApiAccessChecker only applies to projects, returning API [addHost] for
   >  user [User {"username":"admin","uuid":"6ca2d90b-98d3-4e6a-ba3b-328507d9044c"}.] as allowed.
   > 2022-12-02 14:36:53,660 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
   > 2022-12-02 14:36:53,661 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) API rate limiting is disabled. We will not use ApiRateLimitService.
   > 2022-12-02 14:36:53,667 INFO  [c.c.r.ResourceManagerImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Trying to add a new host at http://10.0.33.209 in data center 1
   > 2022-12-02 14:36:53,901 WARN  [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Failed to authenticate with ssh key
   > 2022-12-02 14:36:53,902 ERROR [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Failed to authenticate with ssh key
   > 2022-12-02 14:36:53,927 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: ls /dev/kvm
   > 2022-12-02 14:36:55,159 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: ls /dev/kvm
   > SSH command output:/dev/kvm
   > 
   > 
   > 2022-12-02 14:36:55,171 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   > 2022-12-02 14:36:56,054 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-4:ctx-cb611b95) (logid:78fc051a) HA health check task is running...
   > 2022-12-02 14:36:57,537 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   > SSH command output:
   > 
   > 2022-12-02 14:36:57,597 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > 2022-12-02 14:36:58,864 DEBUG [c.c.c.ConsoleProxyManagerImpl] (consoleproxy-1:ctx-ca157098) (logid:c345ffc8) Skip capacity scan as there is no Primary Storage in 'Up' state
   > 2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > SSH command output:
   > chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   > 
   > 2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > 2022-12-02 14:37:00,055 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-1:ctx-b9a7c1a3) (logid:b4f987fc) HA health check task is running...
   > 2022-12-02 14:37:02,202 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > SSH command output:
   > chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   > 
   > 2022-12-02 14:37:02,202 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > 2022-12-02 14:37:04,058 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-2:ctx-4b9064e6) (logid:88af62e1) HA health check task is running...
   > 2022-12-02 14:37:04,441 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > SSH command output:
   > chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   > 
   > 2022-12-02 14:37:04,443 WARN  [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c)  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   > 2022-12-02 14:37:04,443 DEBUG [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c)  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   > com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   >         at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.setupAgentSecurity(LibvirtServerDiscoverer.java:206)
   >         at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:320)
   >         at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
   >         at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:644)
   >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   >         at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   >         at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   >         at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   >         at com.sun.proxy.$Proxy196.discoverHosts(Unknown Source)
   >         at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
   >         at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
   >         at com.cloud.api.ApiServer.queueCommand(ApiServer.java:776)
   >         at com.cloud.api.ApiServer.handleRequest(ApiServer.java:600)
   >         at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:330)
   >         at com.cloud.api.ApiServlet$1.run(ApiServlet.java:147)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   >         at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:144)
   >         at com.cloud.api.ApiServlet.doGet(ApiServlet.java:98)
   >         at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
   >         at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
   >         at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
   >         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   >         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
   >         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
   >         at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
   >         at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
   >         at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
   >         at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
   >         at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
   >         at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
   >         at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
   >         at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
   >         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
   >         at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
   >         at java.base/java.lang.Thread.run(Thread.java:829)
   > 2022-12-02 14:37:04,444 DEBUG [c.c.r.ResourceManagerImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Could not add host at [http://10.0.33.209] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!].
   > com.cloud.exception.DiscoveredWithErrorException:  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   >         at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:375)
   >         at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
   >         at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:644)
   >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   >         at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   >         at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   >         at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   >         at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   >         at com.sun.proxy.$Proxy196.discoverHosts(Unknown Source)
   >         at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
   >         at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
   >         at com.cloud.api.ApiServer.queueCommand(ApiServer.java:776)
   >         at com.cloud.api.ApiServer.handleRequest(ApiServer.java:600)
   >         at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:330)
   >         at com.cloud.api.ApiServlet$1.run(ApiServlet.java:147)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   >         at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   >         at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:144)
   >         at com.cloud.api.ApiServlet.doGet(ApiServlet.java:98)
   >         at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
   >         at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
   >         at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
   >         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   >         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
   >         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
   >         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
   >         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
   >         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
   >         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
   >         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
   >         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
   >         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
   >         at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
   >         at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
   >         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   >         at org.eclipse.jetty.server.Server.handle(Server.java:516)
   >         at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
   >         at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
   >         at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
   >         at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
   >         at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
   >         at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
   >         at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
   >         at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
   >         at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
   >         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
   >         at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
   >         at java.base/java.lang.Thread.run(Thread.java:829)
   > Caused by: com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   >         at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.setupAgentSecurity(LibvirtServerDiscoverer.java:206)
   >         at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:320)
   >         at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
   >         ... 60 more
   > etc ...
   > ```
   > 
   > I must admit that I do not directly relate this error to your code either, but other PRs are passing so I can not attribute it to the environment either.
   > 
   > the kvm actually fails earlier than with the agent:
   > 
   > ```
   > Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: info : libvirt version: 4.5.0, package: 36.el7_9.5 (CentOS BuildSystem <http://bugs.centos.org>, 2021-04-28-13:32:22, x86-01.bsys.centos.
   > Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: info : hostname: pr6892-t5375-kvm-centos7-kvm1
   > Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: error : virNetTLSContextCheckCertFile:112 : Cannot read private key '/etc/pki/libvirt/private/serverkey.pem': No such file or directory
   > Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 systemd[1]: libvirtd.service: main process exited, code=exited, status=6/NOTCONFIGURED
   > Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 systemd[1]: Failed to start Virtualization daemon.
   > -- Subject: Unit libvirtd.service has failed
   > -- Defined-By: systemd
   > -- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
   > -- 
   > -- Unit libvirtd.service has failed.
   > -- 
   > -- The result is failed.
   > ```
   
   @stephankruggg this still fails. Maybe you can have a look at #6348 it had unexplained errors after changing agent code as well. 
   
   ```
   # systemctl status cloudstack-agent
   ● cloudstack-agent.service - CloudStack Agent
      Loaded: loaded (/usr/lib/systemd/system/cloudstack-agent.service; enabled; vendor preset: disabled)
      Active: inactive (dead)
        Docs: http://www.cloudstack.org/
   ```
   libvirt runs but
   ```
   # systemctl status libvisrtd
   Unit libvisrtd.service could not be found.
   [root@pr6892-t5564-kvm-centos7-kvm2 ~]# systemctl status libvirtd
   ● libvirtd.service - Virtualization daemon
      Loaded: loaded (/usr/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
      Active: active (running) since Mon 2022-12-19 11:21:20 UTC; 37min ago
        Docs: man:libvirtd(8)
              https://libvirt.org
    Main PID: 13795 (libvirtd)
       Tasks: 17 (limit: 32768)
      CGroup: /system.slice/libvirtd.service
              └─13795 /usr/sbin/libvirtd --listen
   
   Dec 19 11:21:20 pr6892-t5564-kvm-centos7-kvm2 systemd[1]: Starting Virtualization daemon...
   Dec 19 11:21:20 pr6892-t5564-kvm-centos7-kvm2 systemd[1]: Started Virtualization daemon.
   Dec 19 11:21:20 pr6892-t5564-kvm-centos7-kvm2 libvirtd[13795]: 2022-12-19 11:21:20.835+0000: 13811: info : libvirt version: 4.5.0, package: 36.el7_9.5 (CentOS BuildSystem <http://bugs.centos.org>, 2021-04-28-13:32:22, x...sys.centos.org)
   Dec 19 11:21:20 pr6892-t5564-kvm-centos7-kvm2 libvirtd[13795]: 2022-12-19 11:21:20.835+0000: 13811: info : hostname: pr6892-t5564-kvm-centos7-kvm2
   Dec 19 11:21:20 pr6892-t5564-kvm-centos7-kvm2 libvirtd[13795]: 2022-12-19 11:21:20.835+0000: 13811: error : virNetDevBridgeCreate:484 : error creating bridge interface virbr0: File exists
   Hint: Some lines were ellipsized, use -l to show in full.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073957316


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   @weizhouapache, you are missing one important point of The Apache Way: "individuals participate at the ASF, not organizations". Again, the community is the contributor's team; if you think some discussing/reviewing/testing is necessary for a PR, you should request the community to it, not a company. For instance, as I already worked with those agent properties, you could have pinged me (as a contributor) for a second opinion.
   
   The contributor is part of the community; if they understand and change the project, they will be able to test and report; and that means the community has resources to manually verify the PR (the contributors themselves are the community). If the contributor will use their resources or their company resources to address the request, it does not matter from ACS as a community. 
   
   As a contributor, I agree that the PR's description is not clear about the use case, and I reinforce your remark: @stephankruggg, could you better explain the use case for this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1074012350


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   @GutoVeronezi 
   you are probably right. I should mention individual contributors who are interested and benefit more from the changes, for example you, João, Rodrigo, Gabriel, Stephan, SadiJr. Hope you are ok with it.
   
   Again, if contributors want to merge a PR as quick as possible, please ask others to test it. Most PRs should not be merged without manual verification (two LGTM/approvals are not good enough).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1403579489

   @stephankruggg would you look at the conflicts again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] stephankruggg commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
stephankruggg commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384158592

   @DaanHoogland, I merged the main and fixed the conflicts; can we try the tests again with this version of the code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
stephankruggg commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072549527


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   (1) The focus of this PR is only the `heartBeatUpdateFreq`. What other variables would you consider necessary to externalize?
   (2) Yes, this will be fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr closed pull request #6892: Externalize KVM HA heartbeat frequency
URL: https://github.com/apache/cloudstack/pull/6892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1812726094

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1813777756

   <b>[SF] Trillian test result (tid-8329)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46510 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t8329-kvm-centos7.zip
   Smoke tests completed. 116 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Failure` | 556.04 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 680.24 | test_kubernetes_clusters.py
   test_08_migrate_vm | `Error` | 44.84 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1759561566

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1754049508

   <b>[SF] Trillian test result (tid-7882)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44539 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t7882-kvm-centos7.zip
   Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_trigger_shutdown | `Failure` | 337.01 | test_safe_shutdown.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 707.07 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1352549956


##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -530,10 +530,10 @@ public class AgentProperties{
     /**
      * Heartbeat update timeout (in ms).<br>
      * Depending on the use case, this timeout might need increasing/decreasing.<br>
-     * Data type: Integer.<br>
-     * Default value: <code>60000</code>
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>
      */
-    public static final Property<Integer> HEARTBEAT_UPDATE_TIMEOUT = new Property<>("heartbeat.update.timeout", 60000);
+    public static final Property<Long> HEARTBEAT_UPDATE_TIMEOUT = new Property<>("heartbeat.update.timeout", 60000l);

Review Comment:
   ```suggestion
       public static final Property<Long> HEARTBEAT_UPDATE_TIMEOUT = new Property<>("heartbeat.update.timeout", 60000L);
   ```



##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
      */
     public static final Property<String> CONTROL_CIDR = new Property<>("control.cidr", "169.254.0.0/16");
 
+    /**
+     * Time interval (in milliseconds) between KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+    /**
+     * Number of maximum tries to KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>5l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new Property<>("kvm.heartbeat.update.max.tries", 5l);
+
+    /**
+     * Time amount (in milliseconds) for the KVM heartbeat retry sleep. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>10000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP = new Property<>("kvm.heartbeat.update.retry.sleep", 10000l);
+
+    /**
+     * Timeout (in milliseconds) of the KVM heartbeat checker. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>360000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_CHECKER_TIMEOUT = new Property<>("kvm.heartbeat.checker.timeout", 360000l);

Review Comment:
   ```suggestion
       public static final Property<Long> KVM_HEARTBEAT_CHECKER_TIMEOUT = new Property<>("kvm.heartbeat.checker.timeout", 360000L);
   ```



##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -530,10 +530,10 @@ public class AgentProperties{
     /**
      * Heartbeat update timeout (in ms).<br>
      * Depending on the use case, this timeout might need increasing/decreasing.<br>
-     * Data type: Integer.<br>
-     * Default value: <code>60000</code>
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>

Review Comment:
   ```suggestion
        * Default value: <code>60000L</code>
   ```



##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
      */
     public static final Property<String> CONTROL_CIDR = new Property<>("control.cidr", "169.254.0.0/16");
 
+    /**
+     * Time interval (in milliseconds) between KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new Property<>("kvm.heartbeat.update.frequency", 60000l);

Review Comment:
   ```suggestion
       public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new Property<>("kvm.heartbeat.update.frequency", 60000L);
   ```



##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
      */
     public static final Property<String> CONTROL_CIDR = new Property<>("control.cidr", "169.254.0.0/16");
 
+    /**
+     * Time interval (in milliseconds) between KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+    /**
+     * Number of maximum tries to KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>5l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new Property<>("kvm.heartbeat.update.max.tries", 5l);
+
+    /**
+     * Time amount (in milliseconds) for the KVM heartbeat retry sleep. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>10000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP = new Property<>("kvm.heartbeat.update.retry.sleep", 10000l);

Review Comment:
   ```suggestion
       public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP = new Property<>("kvm.heartbeat.update.retry.sleep", 10000L);
   ```



##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
      */
     public static final Property<String> CONTROL_CIDR = new Property<>("control.cidr", "169.254.0.0/16");
 
+    /**
+     * Time interval (in milliseconds) between KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>60000l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+    /**
+     * Number of maximum tries to KVM heartbeats. <br>
+     * This property is for KVM only.
+     * Data type: Long.<br>
+     * Default value: <code>5l</code>
+     */
+    public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new Property<>("kvm.heartbeat.update.max.tries", 5l);

Review Comment:
   ```suggestion
       public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new Property<>("kvm.heartbeat.update.max.tries", 5L);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1757758131

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357532971

   <b>Trillian Build Failed (tid-5564)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1329312878

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310015761

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334027266

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334118174

   <b>Trillian Build Failed (tid-5332)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334066248

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1310289375

   <b>Trillian Build Failed (tid-63)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1329312575

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] stephankruggg commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
stephankruggg commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335631869

   > @stephankruggg in my test env I keep seeing this:
   > 
   > ```
   > "2022-12-02 14:36:53 Adding KVM host pr6892-t5375-kvm-centos7-kvm1.", "🙈 Error: (HTTP 530, error code 9999) Could not add host at [http://10.0.33.209/] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!]
   > ```
   > 
   > can you explain that?
   
   Hi, @DaanHoogland, I have not observed this error during my tests. The changes do not seem to affect certificates in KVM, thus, could you send some of the logs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1787292681

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1787407479

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1757775636

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1754549135

   @weizhouapache are you satisfied with this PR now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] github-actions[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1362760310

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by sonarcloud.
sonarcloud[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1403826254

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6892)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL)
   
   [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] codecov[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384214604

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6892?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6892](https://codecov.io/gh/apache/cloudstack/pull/6892?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a20ce80) into [main](https://codecov.io/gh/apache/cloudstack/commit/38f3027a7c99014efad6c3999a4f585d03bde15b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (38f3027) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #6892   +/-   ##
   =========================================
     Coverage     11.77%   11.77%           
   - Complexity     7663     7665    +2     
   =========================================
     Files          2503     2503           
     Lines        245962   245962           
     Branches      38378    38378           
   =========================================
   + Hits          28959    28963    +4     
   + Misses       213238   213233    -5     
   - Partials       3765     3766    +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6892?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/com/cloud/hypervisor/kvm/resource/KVMHABase.java](https://codecov.io/gh/apache/cloudstack/pull/6892?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvS1ZNSEFCYXNlLmphdmE=) | `8.04% <100.00%> (ø)` | |
   | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6892?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386649043

   I'd say ready for merge, but one last pass
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386825704

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1313226706

   <b>Trillian Build Failed (tid-79)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1567950200

   @weizhouapache I marked this for 4.19 as it is based of of main. You think it could go into 4.18.1?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1789752212

   <b>[SF] Trillian test result (tid-8190)</b>
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 44469 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t8190-kvm-alma9.zip
   Smoke tests completed. 115 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1752588058

   @weizhouapache @GutoVeronezi are you okay on this?
   
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1794256799

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1794293836

   ai, conflicts, Can you have a look @GaOrtiga (cc @stephankruggg )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1312707574

   <b>Trillian Build Failed (tid-75)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1312700149

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1337082470

   management:
   ```
   022-12-02 14:36:53,653 DEBUG [c.c.a.ApiServlet] (qtp262366552-16:ctx-738fd6f7) (logid:944d439c) ===START===  10.0.35.111 -- GET  apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&clusterid=a94
   89c75-dbcc-4a51-8081-a76fdff1345b&command=addHost&hypervisor=KVM&podid=1ca6f4d3-fe8b-4eaf-be94-915fcd313a08&response=json&url=http%3A%2F%2F10.0.33.209&username=root&zoneid=ddb1c828-a5eb-4010-83c6-cd9a681a9972&signature=VVRH4DxK1Kow9bs%2B
   jnuzGlWRam0%3D
   2022-12-02 14:36:53,657 DEBUG [c.c.a.ApiServer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) CIDRs from which account 'Account [{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]' is allowed to 
   perform API calls: 0.0.0.0/0,::/0
   2022-12-02 14:36:53,659 INFO  [o.a.c.a.DynamicRoleBasedAPIAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Account [Account [{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]] is Roo
   t Admin or Domain Admin, all APIs are allowed.
   2022-12-02 14:36:53,660 WARN  [o.a.c.a.ProjectRoleBasedApiAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Project is null, ProjectRoleBasedApiAccessChecker only applies to projects, returning API [addHost] for
    user [User {"username":"admin","uuid":"6ca2d90b-98d3-4e6a-ba3b-328507d9044c"}.] as allowed.
   2022-12-02 14:36:53,660 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) RoleService is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
   2022-12-02 14:36:53,661 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) API rate limiting is disabled. We will not use ApiRateLimitService.
   2022-12-02 14:36:53,667 INFO  [c.c.r.ResourceManagerImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Trying to add a new host at http://10.0.33.209 in data center 1
   2022-12-02 14:36:53,901 WARN  [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Failed to authenticate with ssh key
   2022-12-02 14:36:53,902 ERROR [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Failed to authenticate with ssh key
   2022-12-02 14:36:53,927 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: ls /dev/kvm
   2022-12-02 14:36:55,159 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: ls /dev/kvm
   SSH command output:/dev/kvm
   
   
   2022-12-02 14:36:55,171 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   2022-12-02 14:36:56,054 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-4:ctx-cb611b95) (logid:78fc051a) HA health check task is running...
   2022-12-02 14:36:57,537 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   SSH command output:
   
   2022-12-02 14:36:57,597 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   2022-12-02 14:36:58,864 DEBUG [c.c.c.ConsoleProxyManagerImpl] (consoleproxy-1:ctx-ca157098) (logid:c345ffc8) Skip capacity scan as there is no Primary Storage in 'Up' state
   2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   SSH command output:
   chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   
   2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   2022-12-02 14:37:00,055 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-1:ctx-b9a7c1a3) (logid:b4f987fc) HA health check task is running...
   2022-12-02 14:37:02,202 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   SSH command output:
   chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   
   2022-12-02 14:37:02,202 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   2022-12-02 14:37:04,058 DEBUG [o.a.c.h.HAManagerImpl] (BackgroundTaskPollManager-2:ctx-4b9064e6) (logid:88af62e1) HA health check task is running...
   2022-12-02 14:37:04,441 DEBUG [c.c.u.s.SSHCmdHelper] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import /etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   SSH command output:
   chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or directory
   
   2022-12-02 14:37:04,443 WARN  [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c)  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   2022-12-02 14:37:04,443 DEBUG [c.c.h.k.d.LibvirtServerDiscoverer] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c)  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
   com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
           at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.setupAgentSecurity(LibvirtServerDiscoverer.java:206)
           at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:320)
           at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
           at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:644)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.base/java.lang.reflect.Method.invoke(Method.java:566)
           at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
           at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
           at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
           at com.sun.proxy.$Proxy196.discoverHosts(Unknown Source)
           at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
           at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
           at com.cloud.api.ApiServer.queueCommand(ApiServer.java:776)
           at com.cloud.api.ApiServer.handleRequest(ApiServer.java:600)
           at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:330)
           at com.cloud.api.ApiServlet$1.run(ApiServlet.java:147)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
           at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:144)
           at com.cloud.api.ApiServlet.doGet(ApiServlet.java:98)
           at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
           at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
           at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
           at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
           at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
           at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
           at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
           at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
           at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
           at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
           at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
           at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
           at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
           at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
           at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
           at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
           at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
           at java.base/java.lang.Thread.run(Thread.java:829)
   2022-12-02 14:37:04,444 DEBUG [c.c.r.ResourceManagerImpl] (qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) Could not add host at [http://10.0.33.209] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!].
   com.cloud.exception.DiscoveredWithErrorException:  can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
           at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:375)
           at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
           at com.cloud.resource.ResourceManagerImpl.discoverHosts(ResourceManagerImpl.java:644)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.base/java.lang.reflect.Method.invoke(Method.java:566)
           at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
           at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
           at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
           at com.sun.proxy.$Proxy196.discoverHosts(Unknown Source)
           at org.apache.cloudstack.api.command.admin.host.AddHostCmd.execute(AddHostCmd.java:142)
           at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
           at com.cloud.api.ApiServer.queueCommand(ApiServer.java:776)
           at com.cloud.api.ApiServer.handleRequest(ApiServer.java:600)
           at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:330)
           at com.cloud.api.ApiServlet$1.run(ApiServlet.java:147)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
           at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:144)
           at com.cloud.api.ApiServlet.doGet(ApiServlet.java:98)
           at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
           at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
           at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
           at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
           at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
           at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
           at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
           at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
           at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
           at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
           at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
           at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
           at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
           at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
           at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
           at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
           at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
           at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
           at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
           at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
           at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
           at org.eclipse.jetty.server.Server.handle(Server.java:516)
           at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
           at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
           at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
           at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
           at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
           at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
           at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
           at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
           at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
           at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
           at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
           at java.base/java.lang.Thread.run(Thread.java:829)
   Caused by: com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!
           at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.setupAgentSecurity(LibvirtServerDiscoverer.java:206)
           at com.cloud.hypervisor.kvm.discoverer.LibvirtServerDiscoverer.find(LibvirtServerDiscoverer.java:320)
           at com.cloud.resource.ResourceManagerImpl.discoverHostsFull(ResourceManagerImpl.java:811)
           ... 60 more
   etc ...
   ```
   I must admit that I do not directly relate this error to your code either, but other PRs are passing so I can not attribute it to the environment either. 
   
   the kvm actually fails earlier than with the agent:
   ```
   Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: info : libvirt version: 4.5.0, package: 36.el7_9.5 (CentOS BuildSystem <http://bugs.centos.org>, 2021-04-28-13:32:22, x86-01.bsys.centos.
   Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: info : hostname: pr6892-t5375-kvm-centos7-kvm1
   Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 libvirtd[19923]: 2022-12-05 10:08:48.807+0000: 19923: error : virNetTLSContextCheckCertFile:112 : Cannot read private key '/etc/pki/libvirt/private/serverkey.pem': No such file or directory
   Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 systemd[1]: libvirtd.service: main process exited, code=exited, status=6/NOTCONFIGURED
   Dec 05 10:08:48 pr6892-t5375-kvm-centos7-kvm1 systemd[1]: Failed to start Virtualization daemon.
   -- Subject: Unit libvirtd.service has failed
   -- Defined-By: systemd
   -- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
   -- 
   -- Unit libvirtd.service has failed.
   -- 
   -- The result is failed.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1384205570

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6892)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6892&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6892&resolved=false&types=CODE_SMELL)
   
   [![100.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100-16px.png '100.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6892&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072258310


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   @stephankruggg 
   (1) will you add other heartbeat configs to agent.properties as well ?
   (2) can you move the import of "com.cloud.*" near other com.cloud.utils.script.* ?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1386826487

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073789681


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   @GutoVeronezi 
   I think I have clearly expressed my opinion. I have no objection if you want only `kvm.heartbeat.update.frequency` to be configurable, it is ok to me. I also noticed that there are some other related properties can be configurable as well. Do you need me to point them out ? I believe you have noticed them too.
   
   This might happen in the future: the heartbeat update timeout (60seconds) or a setting else is not good, then externalize it to agent.properties. For your company, you need to develop, review, test, release and deploy it again. The community needs to review and test again. It is good if you have discussed it. Hope it will not come true. 
   
   You can of course submit your PRs as individual contributors. The fact we must face is, you/we are also part of a company, most of our changes are based on the company's requirements. The rule of merging PR is, PR can only be merged with 2 approvals (including 1 verification unless it is not required) and smoke tests pass. If you look at the PRs merged recently, most have been verified by @DaanHoogland. However, the community does not have resources to manually test every PR ( I know some PRs have been merged without manual verification, which is not good). I personally encourage the companies which have good resources to test their PRs and share the results, so both the company and the community can benifit from their contribution (including not only creating PRs, but also discussing/reviewing/testing PRs).
   
   Back to the topic, @stephankruggg can you explain a bit why you made this setting configurable, but not for other settings ?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1396177550

   <b>Trillian test result (tid-5891)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41805 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6892-t5891-kvm-centos7.zip
   Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

Posted by "stephankruggg (via GitHub)" <gi...@apache.org>.
stephankruggg commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1083031782


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   The intention of this PR is to allow the increase (or the decrease) of the frequency of the KVM HA heartbeat checks, which is currently not possible. For example, if one wants to guarantee that a critical host is down for the least amount of time possible, one can increase the frequency of the heartbeat with the changes proposed.
   
   Even though not necessarily related to the same use case, the externalization of other properties would achieve the same general goal of increasing the flexibility of the system. Since everyone benefits from this, and they are all related to the same topic (KVM HA), I am open to work on the externalization of them in this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357329624

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357328828

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org