You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/30 01:21:05 UTC
[GitHub] [incubator-druid] gianm commented on a change in pull request
#7795: Fix missing/wrong license
gianm commented on a change in pull request #7795: Fix missing/wrong license
URL: https://github.com/apache/incubator-druid/pull/7795#discussion_r288826140
##########
File path: LICENSE.BINARY
##########
@@ -272,7 +272,7 @@ BINARY/WEB-CONSOLE
This product bundles diff-match-patch version 1.0.4.
- This product bundles @blueprintjs/core version 1.0.1.
+ This product bundles @blueprintjs/core and @blueprintjs/icons of version 3.15.0.
Review comment:
Are these dependency lists and version numbers being updated automatically or are you doing it by hand? If it's by hand, let's think about how to automate it, since this seems like a lot of work!!
By the way, I think to make release managers' lives easier, anything that can't feasibly automated we should try to get done in the PR that makes the original changes. So these changes could have been done in #7398.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org