You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/14 19:43:58 UTC
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6396
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
[DOCS] Genericize cdh_sg_component_kms link
Re-enable an xref that was conditionalized out,
but make it produce plaintext instead of a link.
Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_new_features.xml
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/6396/1
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 1868: cdh
> Just a thought--can we eliminate all references to cdh by changing the name
There's a few like that and I'd like to consider those as a group, so leaving as-is for the moment.
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Files build cleanly, content displays as expected in html & pdf, <keyref> only displays in XML source. Only comment is can we eliminate references to 'cdh' in the <keyref> token names?
http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 1868: cdh
Just a thought--can we eliminate all references to cdh by changing the name of this <keyref> token?
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/101/
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
[DOCS] Genericize cdh_sg_component_kms link
Re-enable an xref that was conditionalized out,
but make it produce plaintext instead of a link.
Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Reviewed-on: http://gerrit.cloudera.org:8080/6396
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_new_features.xml
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize cdh sg component kms link
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Genericize cdh_sg_component_kms link
......................................................................
Patch Set 1:
(1 comment)
sounds reasonable to me.
http://gerrit.cloudera.org:8080/#/c/6396/1/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:
PS1, Line 1868: cdh
> There's a few like that and I'd like to consider those as a group, so leavi
Sounds reasonable to me.
--
To view, visit http://gerrit.cloudera.org:8080/6396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11fcac18533ea07ef03013034d246b8273882c96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes